Adding ability for environment variables and parameters #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Issue #4, Inline html in slack output.
Merge in community changes
Using username/password for auth if specified.
Send message using attachment with color.
as failure to success.
The checkbox is shown along with other options in the build configuration page. If selected, the test summary will be shown in build notifications.
When sending the 'started' notification, no test summary needs to be included.
Tests were failing on my development system Ubuntu 14.04.
failure. This is also related to the request in #15.
New features:
* Advanced settings
* Team domain and token can be specified per project; falls back to
global config if not specified (#19)
* Post a list of commits with the build notification (title and author
of commit) (#30, #44, #45)
* Include JUnit test summary in build notifications (#25)
* Use colors when sending a message using slack (#20, #24). Also, the
start notifications use the color of the last build result (#43)
* Support for authenticated proxies (#14)
* Test Connection button (#46, #28)
* Option to disable subsequent notifications on build failures (#46, #15)
Improvements:
* Report 'return to normal' on transition from unstable to success (#21)
* Improved logging.
Bug fixes:
* When changing the global slack settings the slack config in jobs are
updated as well (#26, #12)
* Fix NullPointerException and output log message if slack is not
configured (#35, JENKINS-26066)
Add build status to README
failure config
It makes sense to group the test connection button with the settings it is actually testing in the advanced section of the slack job config.
space(s) and/or semi-colons as a separator fixes #55
Move test connection button to advanced section
Clarification for newbies like me
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Thanks for the pull request. I don't actively develop this plugin. I maintain releases and pull requests. I'm going to open this up for code review. |
|
Well shoot. That wasn't the right |
|
That's partially my fault. I meant to merge this last week. |
KreAch3R
added a commit
to KreAch3R/slack-plugin
that referenced
this pull request
Dec 24, 2018
Without this, Notifier#perform runs the Slack message publish code too early, resulting in messages like this: ``` test - jenkinsci#68 Success after 6.9 sec and counting (Open) ``` `isBuilding()` should be true in this instance. Instead, always run the plugin with `runAfterFinalised=true.` This restores the older behavior, (before jenkinsci#361, jenkinsci#125) where SlackListener run the publish code after `isBuilding()` was false and the end message was: ``` test - jenkinsci#80 Success after 6 sec (Open) ```
timja
pushed a commit
that referenced
this pull request
Jan 3, 2019
Without this, Notifier#perform runs the Slack message publish code too early, resulting in messages like this: ``` test - #68 Success after 6.9 sec and counting (Open) ``` `isBuilding()` should be true in this instance. Instead, always run the plugin with `runAfterFinalised=true.` This restores the older behavior, (before #361, #125) where SlackListener run the publish code after `isBuilding()` was false and the end message was: ``` test - #80 Success after 6 sec (Open) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability for environment variables and parameters: #31