apply global config #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I guess I'll start maintaining this plugin. I don't have any experience developing Jenkins plugins but if I can get my own environment set up and learn to release then I'll do it. This may take about a week. |
|
How do you think this would affect #19 (if at all)? I'd also like someone to code review this other than me. |
|
I've tested this locally by replicating the buggy behavior and then merging this plugin and seeing that behavior fixed. Since it fixes the bug I'm going to go ahead and merge it. Thanks for the contribution. |
samrocketman
added a commit
that referenced
this pull request
Feb 1, 2015
samrocketman
added a commit
that referenced
this pull request
Feb 10, 2015
New features:
* Advanced settings
* Team domain and token can be specified per project; falls back to
global config if not specified (#19)
* Post a list of commits with the build notification (title and author
of commit) (#30, #44, #45)
* Include JUnit test summary in build notifications (#25)
* Use colors when sending a message using slack (#20, #24). Also, the
start notifications use the color of the last build result (#43)
* Support for authenticated proxies (#14)
* Test Connection button (#46, #28)
* Option to disable subsequent notifications on build failures (#46, #15)
Improvements:
* Report 'return to normal' on transition from unstable to success (#21)
* Improved logging.
Bug fixes:
* When changing the global slack settings the slack config in jobs are
updated as well (#26, #12)
* Fix NullPointerException and output log message if slack is not
configured (#35, JENKINS-26066)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to fix #12 .Could you check my code?