Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't expand parameter values #31

Closed
Brantone opened this issue Nov 24, 2014 · 15 comments
Closed

Doesn't expand parameter values #31

Brantone opened this issue Nov 24, 2014 · 15 comments
Labels

Comments

@Brantone
Copy link
Contributor

When working with condition job step, totally fubarrs ... stack trace to follow.

@Brantone Brantone changed the title Doesn't play nice with Conditional job ste Doesn't play nice with Conditional job step Nov 24, 2014
@samrocketman
Copy link
Member

Any stack trace you can provide?

@samrocketman
Copy link
Member

Versions would be good too:

  • Jenkins version
  • slack plugin version
  • other related plugin versions to help other users debug this.

I do not actively develop this plugin. I am maintaining pull requests and releases from now on.

@Brantone
Copy link
Contributor Author

Brantone commented Feb 4, 2015

Apologies ... I had gotten job logs mixed up, actually not a stack trace, but this shows up in logs:

Feb 04, 2015 2:31:12 AM INFO jenkins.plugins.slack.StandardSlackService publish
Posting: to ${TEMP_SLACK} on [[SNIP]] using https://[[SNIP]].slack.com/services/hooks/jenkins-ci?token=[[SNIP]]: Login_Module_Clients_TEST - #99 Success after 47 sec (<http://[[SNIP]]/|Open>) green

Some values snipped for security reasons.

  • Jenkins version: 1.594
  • Slack version: 1.2
  • Other plugins: a bunch, but affecting this one are MultiJob + ez-template, except even done it with very simple projects.

@samrocketman
Copy link
Member

@Brantone Can you test the latest release? I have released Slack Plugin 1.7.

@Brantone
Copy link
Contributor Author

Digging into bit more the whole "Conditional job step" aspect is bit of misnomer ... it's more on use of parameters and substitution, I'm inclined to actually change title of the Issue to better reflect that.
Incidentally, the latest update to 1.7 introduced another bug ... when editing a job that uses Slack, if I hit "Test Connection" it produces a false positive. Written up as #51

@samrocketman
Copy link
Member

Digging into bit more the whole "Conditional job step" aspect is bit of misnomer ... it's more on use of parameters and substitution,

I'm not sure I understand. Can you please expand on that?

I'm inclined to actually change title of the Issue to better reflect that.

Rename the issue however you like so the problem is aptly described.

@samrocketman
Copy link
Member

If you would like to be invited to https://jenkins-slack-plugin.slack.com/ for testing then just ask.

@Brantone Brantone changed the title Doesn't play nice with Conditional job step Doesn't expand parameter values Feb 25, 2015
@Brantone
Copy link
Contributor Author

Issue renamed ... root-cause for this, is that if I use parameters and set room to "${SLACK_ROOM}" it doesn't actually expand the parameter value. Sure, add me to that slack channel, that'd be great.
Email address made public so you can take a look.

@samrocketman
Copy link
Member

Invite sent.

@Brantone
Copy link
Contributor Author

Received, thx.

@Brantone
Copy link
Contributor Author

Still waiting on merge

@samrocketman
Copy link
Member

Around the 29th a company is having a hackathon and I asked if they would code review currently open PRs. So I'm waiting for that. It's definitely slated for merge, pending feedback.

Brantone added a commit to Brantone/slack-plugin that referenced this issue May 13, 2015
samrocketman added a commit that referenced this issue May 15, 2015
variables and parameters: #31

Conflicts resolved:
	src/main/java/jenkins/plugins/slack/ActiveNotifier.java
@samrocketman
Copy link
Member

Hello, 1.8 has been released. Can you please confirm that this bug is fixed for you? I'm not sure how to effectively test this. Can you please provide the steps to test it else confirm that it is fixed for you?

@Brantone
Copy link
Contributor Author

I'll try to carve out some time to give 'er a go as my currently running instance already has the customizations in SNAPSHOT.

Repro:

  1. Add new parameter: string
  2. Provide name + value, where value = Slack channel name
  3. Use $PARAMETER in place of Slack channel name
  4. Run job and watch for result in Slack channel

@samrocketman
Copy link
Member

Ah thanks, I'll try it out with a parameter :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants