-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't expand parameter values #31
Comments
Any stack trace you can provide? |
Versions would be good too:
I do not actively develop this plugin. I am maintaining pull requests and releases from now on. |
Apologies ... I had gotten job logs mixed up, actually not a stack trace, but this shows up in logs:
Some values snipped for security reasons.
|
@Brantone Can you test the latest release? I have released Slack Plugin 1.7. |
Digging into bit more the whole "Conditional job step" aspect is bit of misnomer ... it's more on use of parameters and substitution, I'm inclined to actually change title of the Issue to better reflect that. |
I'm not sure I understand. Can you please expand on that?
Rename the issue however you like so the problem is aptly described. |
If you would like to be invited to https://jenkins-slack-plugin.slack.com/ for testing then just ask. |
Issue renamed ... root-cause for this, is that if I use parameters and set room to "${SLACK_ROOM}" it doesn't actually expand the parameter value. Sure, add me to that slack channel, that'd be great. |
Invite sent. |
Received, thx. |
Still waiting on merge |
Around the 29th a company is having a hackathon and I asked if they would code review currently open PRs. So I'm waiting for that. It's definitely slated for merge, pending feedback. |
variables and parameters: #31 Conflicts resolved: src/main/java/jenkins/plugins/slack/ActiveNotifier.java
Hello, 1.8 has been released. Can you please confirm that this bug is fixed for you? I'm not sure how to effectively test this. Can you please provide the steps to test it else confirm that it is fixed for you? |
I'll try to carve out some time to give 'er a go as my currently running instance already has the customizations in SNAPSHOT. Repro:
|
Ah thanks, I'll try it out with a parameter :) |
When working with condition job step, totally fubarrs ... stack trace to follow.
The text was updated successfully, but these errors were encountered: