Flip conditional extension of legacy AnnotationDriver class #9843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jun 13, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jun 17, 2022
* 2.13.x: Deprecate omitting the alias in QueryBuilder (doctrine#9765) Run tests on PHP 8.2 (doctrine#9840) PHPStan 1.7.13 (doctrine#9844) Flip conditional extension of legacy AnnotationDriver class (doctrine#9843) PHP CodeSniffer 3.7 (doctrine#9842) Make Reflection available to ConvertMappingCommand (doctrine#9619) Add missing property declaration Use proper API for introspection of tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR flips the if/else block of the conditional
CompatibilityAnnotationDriverclass declaration. I do this to work around a PHPStan bug (see phpstan/phpstan#7290).PHPStan 1.7 basically ignores the
ifblock and picks the first of the two declarations. For projects that have upgraded to Persistence 3 already, PHPStan will complain about code like this:My idea is that the implementation that implements the interface directly is the more correct one. Worst-case scenario with my patch is that PHPStan does not know about the inheritance of the two annotation classes when Persistance 2 is still installed. From my PoV, that's the lesser evil.
cc @VincentLanglet