Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip conditional extension of legacy AnnotationDriver class #2451

Closed
wants to merge 3 commits into from

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Jul 3, 2022

Q A
Type Static Analysis
BC Break no
Fixed issues

Summary

See doctrine/orm#9843

This will allow to remove some of the PHPStan issues and is a work around for phpstan/phpstan#7290.

@franmomu franmomu added the Task label Jul 3, 2022
@malarzm
Copy link
Member

malarzm commented Sep 19, 2022

Some parts of this PR will be incorporated into #2462. Thanks @franmomu for the work you did here!

@malarzm malarzm closed this Sep 19, 2022
@malarzm malarzm reopened this Sep 19, 2022
@malarzm malarzm closed this Sep 19, 2022
@franmomu franmomu deleted the flip_condition branch October 1, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants