Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan 1.7.13 #9844

Merged
merged 1 commit into from
Jun 15, 2022
Merged

PHPStan 1.7.13 #9844

merged 1 commit into from
Jun 15, 2022

Conversation

derrabus
Copy link
Member

No description provided.

@derrabus derrabus added this to the 2.12.3 milestone Jun 13, 2022
@derrabus derrabus changed the title PHPStan 1.7.12 PHPStan 1.7.13 Jun 13, 2022
@@ -16,6 +16,7 @@ parameters:
path: lib/Doctrine/ORM/Tools/Console/ConsoleRunner.php

- '/^Class Doctrine\\DBAL\\Platforms\\(PostgreSQL|SQLServer|SQLAnywhere)Platform not found\.$/'
- '/^Call to method \w+\(\) on an unknown class Doctrine\\DBAL\\Platforms\\(PostgreSQL|SQLServer|SQLAnywhere)Platform\.$/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this happening? Doesn't PHPStan find the DBAL classes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those classes don't exist in DBAL 3.

Copy link
Member Author

@derrabus derrabus Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the SQLAnywhere one at least. The others have been added back in the meantime. I'll try to simplify the rule.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@derrabus derrabus merged commit 6e31758 into doctrine:2.12.x Jun 15, 2022
@derrabus derrabus deleted the bump/phpstan branch June 15, 2022 09:11
derrabus added a commit to derrabus/orm that referenced this pull request Jun 17, 2022
* 2.13.x:
  Deprecate omitting the alias in QueryBuilder (doctrine#9765)
  Run tests on PHP 8.2 (doctrine#9840)
  PHPStan 1.7.13 (doctrine#9844)
  Flip conditional extension of legacy AnnotationDriver class (doctrine#9843)
  PHP CodeSniffer 3.7 (doctrine#9842)
  Make Reflection available to ConvertMappingCommand (doctrine#9619)
  Add missing property declaration
  Use proper API for introspection of tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants