Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 1.46.4 #4082

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Prepare 1.46.4 #4082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@

### Fixed

<a id="1_46_4"></a>

## [1.46.4] - 2024-08-16

### Changed
- Update `@deltachat/stdio-rpc-server` and `deltachat/jsonrpc-client` to `1.142.7`
- Increase timeout for QR generation to 60s #5882
- Fix default to strict TLS checks if not configured #5888
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we more explicitly ask people to change their settings if their account was created on version 1.46.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were not made in dc desktop but in core and are mentioned here only for convenience...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe they should rerun the configuration because "fix: default to strict TLS checks if not configured" might affect which IMAP/SMTP servers are chosen during the configuration. But it doesn't look critical, the new default should apply anyway. CC @link2xt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to rerun configuration. What is changed is that 1.46.4 treats configured_imap_certificate_checks=0 as strict TLS checks if provider is not in the database while 1.46.3 treats this as no certificate checks unless SOCKS5 is enabled.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we cannot change interpretation of configured_imap_certificate_checks=0, this introduced problems for existing setups: deltachat/deltachat-core-rust#5889

Which means core 1.142.6 should also not be released, need to get fix deltachat/deltachat-core-rust#5891 in and tag a new core.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for notifying users, I think we need to introduce a warning that strict TLS is not used in the connectivity view, in general. There are old accounts configured in Delta Chat with C core, they should reconfigure. Only users who configured provider outside the provider database or used advanced settings are affected by the bug in 1.46.3 (core 1.142.4).

- Update rpgp 0.13.2 to fix "unable to decrypt" errors when sending messages to old Delta Chat clients using Ed25519
- Do not request ALPN on standard ports and when using STARTTLS
- for more see [Changelog](https://github.com/deltachat/deltachat-core-rust/blob/v1.142.7/CHANGELOG.md)

<a id="1_46_3"></a>

## [1.46.3] - 2024-08-14
Expand Down Expand Up @@ -2769,7 +2781,9 @@ This section is only relevant to contributors.

**Historical Note 2** We removed the older changelog, you can look at the git history to get it. (version numbers made hallmark crazy)

[unreleased]: https://github.com/deltachat/deltachat-desktop/compare/v1.46.3...HEAD
[unreleased]: https://github.com/deltachat/deltachat-desktop/compare/v1.46.4...HEAD

[1.46.4]: https://github.com/deltachat/deltachat-desktop/compare/v1.46.3...v1.46.4

[1.46.3]: https://github.com/deltachat/deltachat-desktop/compare/v1.46.2...v1.46.3

Expand Down
108 changes: 54 additions & 54 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "deltachat-desktop",
"version": "1.46.3",
"version": "1.46.4",
"description": "Desktop Application for delta.chat",
"main": "index.js",
"type": "module",
Expand Down Expand Up @@ -78,9 +78,9 @@
},
"dependencies": {
"@blueprintjs/core": "^4.20.2",
"@deltachat/jsonrpc-client": "^1.142.4",
"@deltachat/jsonrpc-client": "^1.142.7",
"@deltachat/message_parser_wasm": "^0.11.0",
"@deltachat/stdio-rpc-server": "^1.142.4",
"@deltachat/stdio-rpc-server": "^1.142.7",
"@emoji-mart/data": "1.1.2",
"@emoji-mart/react": "1.1.1",
"application-config": "^1.0.1",
Expand Down Expand Up @@ -111,7 +111,7 @@
"ws": "7.5.10"
},
"devDependencies": {
"@electron/notarize": "^2.3.2",
"@electron/notarize": "2.4",
"@types/chai": "^4.3.16",
"@types/debounce": "^1.2.4",
"@types/emoji-mart": "^3.0.14",
Expand Down
1 change: 1 addition & 0 deletions src/renderer/components/dialogs/AddMember/AddMemberInnerDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ export function AddMemberInnerDialog({
wasSeenRecently: false,
isProfileVerified: false,
isBot: false,
e2eeAvail: false,
}
return (
<ContactListItem
Expand Down
Loading