Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.46.4 #4082

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Prepare 1.46.4 #4082

merged 1 commit into from
Aug 18, 2024

Conversation

nicodh
Copy link
Contributor

@nicodh nicodh commented Aug 16, 2024

No description provided.

- Update `@deltachat/stdio-rpc-server` and `deltachat/jsonrpc-client` to `1.142.6`
- Still try to create "INBOX.DeltaChat" if couldn't create "DeltaChat" #5870
- Increase timeout for QR generation to 60s #5882
- Fix default to strict TLS checks if not configured #5888
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we more explicitly ask people to change their settings if their account was created on version 1.46.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were not made in dc desktop but in core and are mentioned here only for convenience...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe they should rerun the configuration because "fix: default to strict TLS checks if not configured" might affect which IMAP/SMTP servers are chosen during the configuration. But it doesn't look critical, the new default should apply anyway. CC @link2xt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to rerun configuration. What is changed is that 1.46.4 treats configured_imap_certificate_checks=0 as strict TLS checks if provider is not in the database while 1.46.3 treats this as no certificate checks unless SOCKS5 is enabled.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we cannot change interpretation of configured_imap_certificate_checks=0, this introduced problems for existing setups: deltachat/deltachat-core-rust#5889

Which means core 1.142.6 should also not be released, need to get fix deltachat/deltachat-core-rust#5891 in and tag a new core.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for notifying users, I think we need to introduce a warning that strict TLS is not used in the connectivity view, in general. There are old accounts configured in Delta Chat with C core, they should reconfigure. Only users who configured provider outside the provider database or used advanced settings are affected by the bug in 1.46.3 (core 1.142.4).

CHANGELOG.md Outdated Show resolved Hide resolved
@link2xt
Copy link
Collaborator

link2xt commented Aug 17, 2024

Needs core update to 1.142.7

@nicodh nicodh force-pushed the prepare_1.46.4 branch 2 times, most recently from 4fed52e to 22c92be Compare August 18, 2024 08:18
@nicodh
Copy link
Contributor Author

nicodh commented Aug 18, 2024

Updated core to 1.142.7
Added new introduced Contact property e2eeAvail deltachat/deltachat-core-rust@fbf66ba

@nicodh nicodh merged commit 72b1ea2 into main Aug 18, 2024
7 checks passed
@nicodh nicodh deleted the prepare_1.46.4 branch August 18, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants