fix: do not save "Automatic" into configured_imap_certificate_checks #5891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2024
link2xt
force-pushed
the
link2xt/save-strict-tls
branch
2 times, most recently
from
8cca119
to
a214aac
Compare
link2xt
force-pushed
the
link2xt/save-strict-tls
branch
from
a214aac
to
18256f6
Compare
configured_imap_certificate_checks=0 means accept invalid certificates unless provider database says otherwise or SOCKS5 is enabled. It should not be saved into the database anymore. This bug was introduced in <#5854> (commit 6b4532a) and affects released core 1.142.4, 1.142.5 and 1.142.6. Fix reverts faulty fix from <#5886> (commit a268946) which changed the way configured_imap_certificate_checks=0 is interpreted and introduced problems for existing setups with configured_imap_certificate_checks=0: <#5889>. Existing test from previous fix is not reverted and still applies. Regression test is added to check that configured_imap_certificate_checks is not "0" for new accounts.
link2xt
force-pushed
the
link2xt/save-strict-tls
branch
from
18256f6
to
dc19a40
Compare
|
Also added regression test in python. |
iequidoo
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configured_imap_certificate_checks=0 means
accept invalid certificates unless provider database says otherwise or SOCKS5 is enabled.
It should not be saved into the database anymore.
This bug was introduced in
#5854 (commit 6b4532a)
and affects released core 1.142.4, 1.142.5 and 1.142.6.
Fix reverts faulty fix from
#5886 (commit a268946)
which changed the way configured_imap_certificate_checks=0 is interpreted and introduced problems
for existing setups with configured_imap_certificate_checks=0: #5889.
Existing test from previous fix is not reverted
and still applies.
Regression test is added to check that
configured_imap_certificate_checks
is not "0" for new accounts.
Fixes #5889