Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing param for treemap setLabelStyle #11854

Closed
wants to merge 1 commit into from
Closed

Add missing param for treemap setLabelStyle #11854

wants to merge 1 commit into from

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Dec 15, 2019 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Pass missing series model to setLabelStyle to retrieve label
Close #11772

Before: What was the problem?

emphasis.label.formatter is not working

After: How is it fixed in this PR?

emphasis.label.formatter is working

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@pissang pissang requested a review from 100pah December 23, 2019 07:35
@pissang pissang added this to the 4.8.0 milestone Dec 30, 2019
@susiwen8 susiwen8 self-assigned this Mar 2, 2020
@NsNe
Copy link

NsNe commented Mar 5, 2020

How can i solve this?

100pah
100pah approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@100pah 100pah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some more modification about this fix.
I am adding it.

pull bot pushed a commit to ws1993/incubator-echarts that referenced this pull request Apr 21, 2020
@100pah
Merge pull request apache#11854 from susiwen8/apache#11772
11da045 
Add missing param for treemap setLabelStyle
100pah added a commit that referenced this pull request Apr 21, 2020
@100pah
fix: Enable treemap emphasis label formatter. Fix #11854. And add tes…
1a8162d 
…t cases.

Note: the implementation of "insert levelModel" is modified from "Tree.getModel"
to "beforeLink  nodeData.wrapMethod('getItemModel', ...)", because the former
one miss the case of `data.getItemModel`, which is needed in label formatter fetcher.
@100pah 100pah mentioned this pull request Apr 21, 2020
Merged
@100pah
Copy link
Member

100pah commented Apr 21, 2020

Have been merged in git.

@100pah 100pah closed this Apr 21, 2020
100pah added a commit that referenced this pull request Apr 22, 2020
@100pah
fix: Enable treemap emphasis label formatter. Fix #11854. And add tes…
8c2267d 
…t cases.

Note: the implementation of "insert levelModel" is modified from "Tree.getModel"
to "beforeLink  nodeData.wrapMethod('getItemModel', ...)", because the former
one miss the case of `data.getItemModel`, which is needed in label formatter fetcher.
100pah added a commit that referenced this pull request Feb 19, 2021
@100pah
This code has been modified in 8c2267d (see #11854) and merge into ne…
2a49feb 
…xt branch in dd3d83c,

but in 58dc3f7 the merge was not correct enough (it cause the drillDownIcon displayed repeatedly in some case).
So fix it according to 8c2267d. And add the missing test case.
@100pah 100pah mentioned this pull request Feb 19, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100pah 100pah 100pah approved these changes

Assignees

@susiwen8 susiwen8

Labels
PR: author is committer PR: awaiting review
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

treemap 属性emphasis.label.formatter不生效
5 participants
@susiwen8 @NsNe @100pah @Ovilia @pissang