Fix/treemap emphasis #12471
Merged
Fix/treemap emphasis #12471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`leavesModel` should be inserted between the node `itemModel` and the `seriesModel` in the "parentModel" chain.
It can be added either via [A] "beforeLink - nodeData.wrapMethod('getItemModel, ...)"
or via [B] "TreeNode.getModel ".
But `TreeSeres` both use the two strategy, which causes the `leavesModel` is inserted twice.
In fact the strategy [A] have some defect (do not cover the case `data.getItemModel(...)`).
So [A] should not be used any more. [B] is recommended.
…t cases.
Note: the implementation of "insert levelModel" is modified from "Tree.getModel"
to "beforeLink nodeData.wrapMethod('getItemModel', ...)", because the former
one miss the case of `data.getItemModel`, which is needed in label formatter fetcher.
This was referenced Apr 21, 2020
pissang
approved these changes
Apr 22, 2020
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable treemap emphasis label formatter. Fix Add missing param for treemap setLabelStyle #11854. And add test cases.
[Details]:
The implementation of "insert levelModel" is migrate from "Tree.getModel"
to "beforeLink nodeData.wrapMethod('getItemModel', ...)", because the former
one miss the case of
data.getItemModel, which is needed in label formatter fetcher.Fix the incorrect implementation of
leavesModelinTreeSeries.This defect is found when fix "1". "1" and "2" are sharing the same data structure (Tree, insert model) so we'd better fix them together.
[Details]:
leavesModelshould be inserted between the nodeitemModeland theseriesModelin the "parentModel" chain.It can be added either via [A] "beforeLink - nodeData.wrapMethod('getItemModel, ...)"
or via [B] "TreeNode.getModel ".
But
TreeSeresboth use the two strategy, which causes theleavesModelis inserted twice.