Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix treemap display drill-down icon repeatedly. #14299

Merged
merged 1 commit into from
Feb 19, 2021
Merged

fix treemap display drill-down icon repeatedly. #14299

merged 1 commit into from
Feb 19, 2021

Conversation

100pah
Copy link
Member

@100pah 100pah commented Feb 19, 2021

This code has been modified in 8c2267d (see #11854) and merge into next branch in dd3d83c,
but in 58dc3f7 the merge was not correct enough (it cause the drillDownIcon displayed repeatedly in some case).
So fix it according to 8c2267d.

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

@100pah
This code has been modified in 8c2267d (see #11854) and merge into ne…
2a49feb 
…xt branch in dd3d83c,

but in 58dc3f7 the merge was not correct enough (it cause the drillDownIcon displayed repeatedly in some case).
So fix it according to 8c2267d. And add the missing test case.
@echarts-bot
Copy link

echarts-bot bot commented Feb 19, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@100pah 100pah merged commit e893d90 into master Feb 19, 2021
@100pah 100pah deleted the fix/treemap-expand branch February 19, 2021 13:56
@echarts-bot
Copy link

echarts-bot bot commented Feb 19, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@MilosPopovic11
Copy link

Hi, this doesn't have nothing with this subject, but I need to ask something that I try to find solution on DOCS, on Stack, in PRs, and in Issues, and can not find, and I am not sure if that is for new feature or bug.
Is there a way for treemap that have multilevels, to have SUM of all values for that level?
ex. If I am on first leaf level, I need TOTAL SUM of all values from that level to show to user, when click on some child leaf, need to get TOTAL SUM of all values from that level etc... Thanks and sorry for interrupt.

@swsoyee swsoyee mentioned this pull request Jun 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@100pah @MilosPopovic11 @pissang