-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor commands [WIP] #234
Conversation
Actions.allActions.push(new action()); | ||
} | ||
|
||
@RegisterAction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oohh! neat, didn't know TS/JS had this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's really snazzy. Unfortunately I'm running into some annoying bugs where depending on compile order things might not work, so I might have to remove it...
This new abstraction handles motions like dw by default! Woo!
I'm sure there are other things that need to be special cased. But I don't know what they are, yet.
TypeScript was having some issues with files with circular dependencies.
This cleans up a lot of edge cases and small bugs nicely!
This makes all the actions stateless and beautiful. : )
Bah! The tests totally pass. I don't understand why they're timing out on the server. I'LL JUST DO IT LIVE!!! |
Stuff I did:
h
), operators (e.g.d
) and commands (e.g.i
). There may be more? I'm not sure.5"pdw
, it'll gather:p
registerw
and does the whole thing.dw
,y}
- commands that spell out an operation and a movement to do it over - in a unified manner rather than special casing all of them.aw
andiw
movements work as arguments tod
,y
andc
.