Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor commands [WIP] #234

Merged
merged 57 commits into from
Jun 5, 2016
Merged

Refactor commands [WIP] #234

merged 57 commits into from
Jun 5, 2016

Commits on May 29, 2016

  1. Begin command refactor.

    @johnfn
    johnfn committed May 29, 2016
    Configuration menu
    Copy the full SHA
    83afbcf View commit details
    Browse the repository at this point in the history

  2. Add the remaining keys.

    @johnfn
    johnfn committed May 29, 2016
    Configuration menu
    Copy the full SHA
    13fdd4c View commit details
    Browse the repository at this point in the history

  3. Passing most tests.

    @johnfn
    johnfn committed May 29, 2016
    Configuration menu
    Copy the full SHA
    f160a86 View commit details
    Browse the repository at this point in the history

  4. Finish up normal mode rewrite.

    @johnfn
    johnfn committed May 29, 2016
    Configuration menu
    Copy the full SHA
    49b8a2f View commit details
    Browse the repository at this point in the history

  5. Refactor actions to return positions.

    @johnfn
    johnfn committed May 29, 2016
    Configuration menu
    Copy the full SHA
    7675cb6 View commit details
    Browse the repository at this point in the history

  6. Refactor Normal & Visual mode to use same actions

    @johnfn
    johnfn committed May 29, 2016
    Configuration menu
    Copy the full SHA
    bf5c42e View commit details
    Browse the repository at this point in the history

  7. Rewrite modes to take Actions, not key presses.

    @johnfn
    johnfn committed May 29, 2016
    Configuration menu
    Copy the full SHA
    7d15fff View commit details
    Browse the repository at this point in the history

  8. Make operators inherit from a common base class.

    @johnfn
    johnfn committed May 29, 2016
    Configuration menu
    Copy the full SHA
    ee15155 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2016

  1. Track action state in ModeHandler and write core processing fn.

    @johnfn
    johnfn committed May 30, 2016
    Configuration menu
    Copy the full SHA
    409822f View commit details
    Browse the repository at this point in the history

  2. Remove a bunch of stuff. 

    This new abstraction handles motions like dw by default! Woo!
    @johnfn
    johnfn committed May 30, 2016
    Configuration menu
    Copy the full SHA
    a6d01bd View commit details
    Browse the repository at this point in the history

  3. Respect modes for actions.

    @johnfn
    johnfn committed May 30, 2016
    Configuration menu
    Copy the full SHA
    c6db2d5 View commit details
    Browse the repository at this point in the history

  4. Make all state transitions into Actions.

    @johnfn
    johnfn committed May 30, 2016
    Configuration menu
    Copy the full SHA
    0b52969 View commit details
    Browse the repository at this point in the history

  5. Clean up, fix <esc>.

    @johnfn
    johnfn committed May 30, 2016
    Configuration menu
    Copy the full SHA
    06ae75f View commit details
    Browse the repository at this point in the history

  6. Add x/X actions.

    @johnfn
    johnfn committed May 30, 2016
    Configuration menu
    Copy the full SHA
    3f2df04 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2016

  1. Handle a lot of weird edge cases.

    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    e0eb20c View commit details
    Browse the repository at this point in the history

  2. Add a special case JUST for de. 

    I'm sure there are other things that need to be special cased. But I
don't know what they are, yet.
    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    97c615c View commit details
    Browse the repository at this point in the history

  3. Add C.

    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    8fe79c9 View commit details
    Browse the repository at this point in the history

  4. Shove everything in one massive class. 

    TypeScript was having some issues with files with circular dependencies.
    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    b87a41a View commit details
    Browse the repository at this point in the history

  5. Fix cw.

    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    f6d90dd View commit details
    Browse the repository at this point in the history

  6. Fix cW as well.

    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    bc8d0fe View commit details
    Browse the repository at this point in the history

  7. Pass all [operator][motion] normal mode tests!

    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    5bde23c View commit details
    Browse the repository at this point in the history

  8. Begin adding/rewriting visual mode tests.

    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    c3683f0 View commit details
    Browse the repository at this point in the history

  9. Fix all visual mode tests!

    @johnfn
    johnfn committed May 31, 2016
    Configuration menu
    Copy the full SHA
    8a6c826 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2016

  1. Fix a bug with deleting in Visual Mode.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    0fce025 View commit details
    Browse the repository at this point in the history

  2. Fix gg, and refactor some logic along the way.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    da30a64 View commit details
    Browse the repository at this point in the history

  3. Add test for gg.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    e84f583 View commit details
    Browse the repository at this point in the history

  4. Refactor a lot of deletes to use DeleteOperator. 

    This cleans up a lot of edge cases and small bugs nicely!
    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    beef8a6 View commit details
    Browse the repository at this point in the history

  5. Make DeleteOperator inclusive/exclusive.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    87a3d99 View commit details
    Browse the repository at this point in the history

  6. Remove an unused function.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    8019bbe View commit details
    Browse the repository at this point in the history

  7. Fix off-by-one in reverse ranges.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    4b43b73 View commit details
    Browse the repository at this point in the history

  8. Add VimState, keep track of desired column again.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    a9476af View commit details
    Browse the repository at this point in the history

  9. Clean up desiredColumn and add test.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    35eefbe View commit details
    Browse the repository at this point in the history

  10. Nest ActionState within VimState.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    4982f4b View commit details
    Browse the repository at this point in the history

  11. Nest ActionState within VimState and return VimState from actions.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    1114f9b View commit details
    Browse the repository at this point in the history

  12. Don't pass ActionState, only VimState.

    @johnfn
    johnfn committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    9e055d6 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2016

  1. Refactor the 'ready to run' logic.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    a6c2144 View commit details
    Browse the repository at this point in the history

  2. Fix dl at end of line and add test.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    af00ab7 View commit details
    Browse the repository at this point in the history

  3. Add commands like $ force desiredColumn to EOL.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    b7ecb56 View commit details
    Browse the repository at this point in the history

  4. Handle the returned VimState in a unified way.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    00cad54 View commit details
    Browse the repository at this point in the history

  5. Simplify logic.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    7410857 View commit details
    Browse the repository at this point in the history

  6. Update mode via VimState.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    f9fed66 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary parameter.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    f837304 View commit details
    Browse the repository at this point in the history

  8. Remove handleDeactivation, which caused weird bugs.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    0f3fa9e View commit details
    Browse the repository at this point in the history

  9. Stop passing in modeHandler to actions. 

    This makes all the actions stateless and beautiful. : )
    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    e905f40 View commit details
    Browse the repository at this point in the history

  10. Add a bunch of commands.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    0fc8e94 View commit details
    Browse the repository at this point in the history

  11. Add 2 more commands back.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    efc6133 View commit details
    Browse the repository at this point in the history

  12. Add x operator in visual mode.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    37a6abb View commit details
    Browse the repository at this point in the history

  13. Add yank and put back.

    @johnfn
    johnfn committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    1a0cbb9 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2016

  1. Add text object and remove concept of inclusive/exclusive motions.

    @johnfn
    johnfn committed Jun 4, 2016
    Configuration menu
    Copy the full SHA
    e0e6974 View commit details
    Browse the repository at this point in the history

  2. Totally remove position options.

    @johnfn
    johnfn committed Jun 4, 2016
    Configuration menu
    Copy the full SHA
    b662bad View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2016

  1. Text objects work with d/c/y!!

    @johnfn
    johnfn committed Jun 5, 2016
    Configuration menu
    Copy the full SHA
    85b6d8c View commit details
    Browse the repository at this point in the history

  2. Add iw text object.

    @johnfn
    johnfn committed Jun 5, 2016
    Configuration menu
    Copy the full SHA
    88f2e57 View commit details
    Browse the repository at this point in the history

  3. Fix an 'aw' bug.

    @johnfn
    johnfn committed Jun 5, 2016
    Configuration menu
    Copy the full SHA
    3143f14 View commit details
    Browse the repository at this point in the history

  4. Make "aw" motion work and pass tests.

    @johnfn
    johnfn committed Jun 5, 2016
    Configuration menu
    Copy the full SHA
    d320241 View commit details
    Browse the repository at this point in the history

  5. Fix iw motion.

    @johnfn
    johnfn committed Jun 5, 2016
    Configuration menu
    Copy the full SHA
    cab7dd4 View commit details
    Browse the repository at this point in the history

  6. Add put test and pass all tests.

    @johnfn
    johnfn committed Jun 5, 2016
    Configuration menu
    Copy the full SHA
    668dfa1 View commit details
    Browse the repository at this point in the history

  7. Fix all tslint errors.

    @johnfn
    johnfn committed Jun 5, 2016
    Configuration menu
    Copy the full SHA
    3ce1c28 View commit details
    Browse the repository at this point in the history