Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s keybinding #235

Merged
merged 1 commit into from
Jun 5, 2016
Merged

Add s keybinding #235

merged 1 commit into from
Jun 5, 2016

Conversation

Paxxi
Copy link
Contributor

@Paxxi Paxxi commented Jun 4, 2016

This is one of the keybindings I use quite often and felt was missing

@johnfn
Copy link
Member

johnfn commented Jun 4, 2016

Hi @Paxxi! I'm currently in the middle of an enormous refactor that I'm looking to get merged in the next couple of days, which has changed how we add new keybindings: #234

If you can find time, try to add it there. Or I will eventually add it in myself.

Thanks!

@Paxxi
Copy link
Contributor Author

Paxxi commented Jun 5, 2016

I'll add it there instead, planning on more work time permitting so no problems. Really want to get some feature parity with the vim bindings for atom so I can make the switch

@Paxxi
Copy link
Contributor Author

Paxxi commented Jun 5, 2016

Should be updated against current master now and tests are passing

Accidentaly messed up a merge so the rurnning travis build may be broken but it's fixed now.

@johnfn johnfn merged commit c671c16 into VSCodeVim:master Jun 5, 2016
@johnfn
Copy link
Member

johnfn commented Jun 5, 2016

Great! Thanks a bunch for the contribution! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants