(fix) colima: fix return code handling (followup to #3097)

.github/workflows/run-unit-tests.yml

@@ -87,35 +87,53 @@ jobs:
 
           export DOCKER_CONTEXT="colima-$GITHUB_RUN_ID"
           docker context create $DOCKER_CONTEXT --docker host=unix:///var/run/docker.sock
+          docker context use $DOCKER_CONTEXT
 
           start_colima() {
-            # Find a free port
-            RANDOM_PORT=$((RANDOM % 16384 + 49152))
+            # Find a free port in the range 10000-20000
+            RANDOM_PORT=$((RANDOM % 10001 + 10000))
 
             echo "Using random port: $RANDOM_PORT for SSH"
 
-            colima start --network-address --arch x86_64 --cpu=1 --memory=1 --ssh-port $RANDOM_PORT
-            docker context use $DOCKER_CONTEXT
+            if ! colima start --network-address --arch x86_64 --cpu=1 --memory=1 --verbose --ssh-port $RANDOM_PORT; then
+              echo "Failed to start Colima."
+              return 1
+            fi
           }
 
-          # Attempt to start Colima
-          ATTEMPT_LIMIT=3
+          # Attempt to start Colima; 4 retries:
+          ATTEMPT_LIMIT=5
           for ((i=1; i<=ATTEMPT_LIMIT; i++)); do
             if start_colima; then
               echo "Colima started successfully."
               break
             else
               echo "Failed to start Colima. Attempt $i/$ATTEMPT_LIMIT."
-              if [ $i -eq $ATTEMPT_LIMIT ]; then
-                colima delete
+              echo "Colima logs:"
+              if [ -f /opt/homebrew/var/log/colima.log ]; then
+                cat /opt/homebrew/var/log/colima.log
               else
+                echo "Colima log file not found at /opt/homebrew/var/log/colima.log"
+                ls -l /opt/homebrew/var/log/
+              fi
+              if [ $i -lt $ATTEMPT_LIMIT ]; then
+                echo "Stopping Colima forcefully..."
                 colima stop -f
+                ecthe "ho "Waiting 10 seconds before next attempt..."
+                sleep 10
               fi
             fi
           done
 
-          if [ $i -gt $ATTEMPT_LIMIT ]; then
+          if [ $i -eq $ATTEMPT_LIMIT ]; then
             echo "Failed to start Colima after $ATTEMPT_LIMIT attempts."
+            echo "Final Colima logs:"
+            if [ -f /opt/homebrew/var/log/colima.log ]; then
+              cat /opt/homebrew/var/log/colima.log
+            else
+              echo "Colima log file not found at /opt/homebrew/var/log/colima.log"
+              ls -l /opt/homebrew/var/log/
+            fi
             exit 1
           fi