-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) colima: fix return code handling (followup to #3097) #3106
Conversation
@SmartManoj This should work better now, right? |
@SmartManoj I've removed the "docker context" approach again. |
Oops a copy/paste error, one sec.... |
Github runner has only one IP. right? |
I don't know, will see where it fails 😂 |
For a single runner during running. Docs |
Thanks. I'll give it one more try with |
But here we are using a local IP address only, not an external IP. So the docs don't apply in this case, I think. |
oh well, doesn't work with limactl neither, so going to remove that again ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try!
可望打造新的 |
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Fixes #3097
colima start
command being passed to the outer loop.