Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) colima: fix return code handling (followup to #3097) #3106

Merged
merged 20 commits into from
Jul 25, 2024

Conversation

tobitege
Copy link
Collaborator

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

Fixes #3097

  • This fixes the exit code of the colima start command being passed to the outer loop.
  • Added a 10 second delay before retry.
  • Increased to 5 total attempts (4 retries).
  • Added "--verbose" flag and lowered random port range to 10000-20000

@tobitege tobitege added backend Related to backend test Test cases and testing framework changes labels Jul 25, 2024
@tobitege tobitege requested a review from xingyaoww July 25, 2024 10:33
@tobitege
Copy link
Collaborator Author

@SmartManoj This should work better now, right?

@tobitege
Copy link
Collaborator Author

@SmartManoj I've removed the "docker context" approach again.
Trying the loop with install and delete now. Also added that the IP will increase with every attempt.
From what I've seen thus far, it is the local IP address that it can't "resolve" or is blocked from using.
Bit of trial and error... 😔

@tobitege
Copy link
Collaborator Author

Oops a copy/paste error, one sec....

@SmartManoj
Copy link
Contributor

SmartManoj commented Jul 25, 2024

Github runner has only one IP. right?

@tobitege
Copy link
Collaborator Author

Github runner has only one IP. right?

I don't know, will see where it fails 😂

@SmartManoj
Copy link
Contributor

SmartManoj commented Jul 25, 2024

Github runner has only one IP. right?

For a single runner during running. Docs

@tobitege
Copy link
Collaborator Author

Github runner has only one IP. right?

For a single runner during running. Docs

Thanks. I'll give it one more try with limactl create colima-${IP_ADDRESS} next and if that fails, will revert that IP changing as well.

@tobitege
Copy link
Collaborator Author

Github runner has only one IP. right?

For a single runner during running. Docs

But here we are using a local IP address only, not an external IP. So the docs don't apply in this case, I think.

@tobitege
Copy link
Collaborator Author

oh well, doesn't work with limactl neither, so going to remove that again ...

Copy link
Contributor

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try!

@xingyaoww xingyaoww merged commit 22c7bca into All-Hands-AI:main Jul 25, 2024
2 checks passed
@tobitege tobitege deleted the colima branch July 25, 2024 19:24
@WEI567
Copy link

WEI567 commented Aug 23, 2024

可望打造新的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend test Test cases and testing framework changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants