Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) colima: fix return code handling (followup to #3097) #3106

Merged
merged 20 commits into from
Jul 25, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
moved docker context outside of function
  • Loading branch information
tobitege committed Jul 25, 2024
commit c864a4a5ae5fd456ef04940c768628170278ea96
2 changes: 1 addition & 1 deletion .github/workflows/run-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@ jobs:
echo "Failed to start Colima."
return 1
fi
docker context use $DOCKER_CONTEXT
}

# Attempt to start Colima; 4 retries:
tobitege marked this conversation as resolved.
Show resolved Hide resolved
ATTEMPT_LIMIT=5
for ((i=1; i<=ATTEMPT_LIMIT; i++)); do
if start_colima; then
echo "Colima started successfully."
docker context use $DOCKER_CONTEXT
break
else
echo "Failed to start Colima. Attempt $i/$ATTEMPT_LIMIT."
Expand Down