Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation update (Danish) #824

Merged
merged 7 commits into from
Nov 4, 2020
Merged

Translation update (Danish) #824

merged 7 commits into from
Nov 4, 2020

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Oct 25, 2020 •
edited
Loading

PR #821 was based on master branch instead of develop branch and created conflicts when created against develop branch. This PR is meant to be a replacement of #821.

  • Commit 5acd6a5 is created by cherry-picking the commit 58ae64f from Translation update #821 and accepting everything from that.
  • Commit d1a36b3 remove some duplicate or misplaced entries in the resulting da.po.
  • Commit 03a9d53 adjusts all lines (msgstr) to the standard line lenghts (no change of content).

@matsduf matsduf added P-High Priority: Issue to be solved before other A-Translation Area: Documentation of, implementation of or actual translation of text labels Oct 25, 2020
@matsduf matsduf added this to the v2020.1 milestone Oct 25, 2020
@matsduf matsduf requested review from mattias-p, sandoche2k and a user October 25, 2020 13:40
@matsduf matsduf mentioned this pull request Oct 25, 2020
Closed
@matsduf
Copy link
Contributor Author

matsduf commented Oct 25, 2020

The entire file can be inspected by https://github.com/zonemaster/zonemaster-engine/blob/03a9d5314c28ea5c0ba307e3354a100582c5dc4f/share/da.po

To download the entire file, use https://raw.githubusercontent.com/zonemaster/zonemaster-engine/03a9d5314c28ea5c0ba307e3354a100582c5dc4f/share/da.po

mattias-p
mattias-p reviewed Oct 26, 2020
View reviewed changes
share/da.po Outdated Show resolved Hide resolved
@matsduf
Copy link
Contributor Author

matsduf commented Oct 26, 2020

@mattias-p, please re-review.

mattias-p
mattias-p reviewed Oct 26, 2020
View reviewed changes
share/da.po Outdated Show resolved Hide resolved
mattias-p
mattias-p reviewed Oct 26, 2020
View reviewed changes
share/da.po Outdated Show resolved Hide resolved
@matsduf
Copy link
Contributor Author

matsduf commented Oct 26, 2020

@mattias-p, please re-review.

@matsduf matsduf linked an issue Oct 27, 2020 that may be closed by this pull request
Updated Danish translation #810
Closed
sandoche2k
sandoche2k previously approved these changes Nov 3, 2020
View reviewed changes
@matsduf
Copy link
Contributor Author

matsduf commented Nov 4, 2020

Corrected and updated. Please re-review, @mattias-p and @sandoche2k.

@matsduf matsduf merged commit aa038f7 into zonemaster:develop Nov 4, 2020
@matsduf matsduf deleted the translate-danish branch November 4, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattias-p mattias-p mattias-p approved these changes

@sandoche2k sandoche2k sandoche2k approved these changes

Assignees
No one assigned
Labels
A-Translation Area: Documentation of, implementation of or actual translation of text P-High Priority: Issue to be solved before other
Projects
None yet
Milestone
v2020.1
Development

Successfully merging this pull request may close these issues.

Updated Danish translation
4 participants
@matsduf @mattias-p @sandoche2k @haarbo