Remove empty elements from @keys to resolve issue #727 #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
added
the
A-TestCase
vlevigneron
approved these changes
May 12, 2020
| @@ -1880,6 +1880,14 @@ sub dnssec13 { | |||
|
|
|||
| foreach my $sig ( @sigs ) { | |||
| my @keys = ($keytags{$sig->keytag}); | |||
There was a problem hiding this comment.
I guess the following line would be enough:
my @keys = grep { $_ } ($keytags{$sig->keytag});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #727.
Zonemaster::LDNS::RR::RRSIG::verify()requires that incoming parameter$keysis a reference to a non-empty array of DNSKEYs. Under some circumstances,@keysin Zonemaster::Engine::Test::DNSSEC::dnssec13() is created as an array of an empty key, and is then validated as non-empty and used in a call toZonemaster::LDNS::RR::RRSIG::verify().This update removes any empty element from
@keysafter it is created.