Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for fix 728? #730

Open
matsduf opened this issue May 13, 2020 · 0 comments
Open

Unit test for fix 728? #730

matsduf opened this issue May 13, 2020 · 0 comments
Labels
A-TestCase Area: Test case specification or implementation of test case
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented May 13, 2020

A bug in Zonemaster-Engine was fixed by PR #728, but no unit tests have been created.

Data was collected with the following commands after #728 (but nothing else) was applied Zonemaster v2019.2. The data files are attached in attach-issue-zonemaster-engine-730.tar.gz
.

zonemaster-cli ed25519.nl --no-ipv6 --raw --test DNSSEC/dnssec13 --save ~/ed25519.nl-dnssec13-with-fix-728.data
zonemaster-cli ip.se --no-ipv6 --raw --test DNSSEC/dnssec13 --save ~/ip.se-dnssec13-with-fix-728.data

The tests files have been verified with the following command, run both with and without #728 applied:

zonemaster-cli ed25519.nl --no-ipv6 --raw --test DNSSEC/dnssec13 --restore  ~/ed25519.nl-dnssec13-with-fix-728.data
zonemaster-cli ip.se --no-ipv6 --raw --test DNSSEC/dnssec13 --restore  ~/ip.se-dnssec13-with-fix-728.data

A test zone that triggers the bug, without the fix, should be set up.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label May 13, 2020
@matsduf matsduf modified the milestones: v2019.2.1, v2020.1 May 13, 2020
@matsduf matsduf modified the milestones: v2020.1, v2020.2 Sep 14, 2020
@matsduf matsduf modified the milestones: v2020.2, v2021.2 Feb 8, 2021
@matsduf matsduf modified the milestones: v2021.2, v2022.1 Dec 8, 2021
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case
Projects
None yet
Development

No branches or pull requests

1 participant