Make test module auto-detection less dynamic #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is makes us resilient to situations where Z::E was updated but the old verision was not properly cleaned up. It really helps on buggy SaaS CI platforms where we don't have full control over the machines being used.
mattias-p
force-pushed
the
resilient-modules
branch
from
e2fc3f4
to
fa20218
Compare
matsduf
requested changes
Aug 12, 2019
| map { my $f = $_; $f =~ s|^Zonemaster::Engine::Test::||; $f } | ||
| grep { $_ ne 'Zonemaster::Engine::Test::Basic' } useall( 'Zonemaster::Engine::Test' ); | ||
| BEGIN { | ||
| @all_test_modules = split /\n/, read_file( dist_file( 'Zonemaster-Engine', 'modules.txt' ) ); |
There was a problem hiding this comment.
Is this really the best solution? Isn't better to create a perl module that lists the modules? I feel that the code would be simpler and more direct.
There was a problem hiding this comment.
I just want to fix a bug here. As such I'm trying to change the design as little as possible.
Feel free to create an issue to make the module listing completely static.
matsduf
approved these changes
Oct 1, 2019
|
@vlevigneron to review |
vlevigneron
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a problem with Travis failing for zonemaster-backend.
The problem caused by Travis installing a newer version of Z::E being on top of an older version without properly cleaning up older version. A module named Z::E::Test::Example existed in the older version but was removed in the newer one. In addition to this there was an API change causing the old version of Z::E::Test::Example to be incompatible with the new version of Z::E.
The problem is solved by auto-detecting the Z::E::Test modules once and for all at configure-time instead of looking for any modules under the Z::E::Test namespace at run-time.
As a drive-by fix I also added to remove the necessity to install Z::E in @inc in development mode.