Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to debug Travis problem #538

Closed
wants to merge 12 commits into from
Closed

Try to debug Travis problem #538

wants to merge 12 commits into from

Conversation

mattias-p
Copy link
Member

No description provided.

@mattias-p mattias-p force-pushed the travis branch 4 times, most recently from 8498411 to ee4a209 Compare August 6, 2019 09:55
@mattias-p mattias-p force-pushed the travis branch 4 times, most recently from 4b1d53b to 6d4747b Compare August 9, 2019 14:32
@mattias-p
Copy link
Member Author

I believe the Can't locate object method "tag_descriptions" via package "Zonemaster::Engine::Test::Example" will be solved by zonemaster/zonemaster-engine#580. That leaves the MySQL error.

@mattias-p
Copy link
Member Author

The user hosts update got us further (08f075f), but the default value change did nothing (01c9f45).

mtoma
mtoma reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@mtoma mtoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattias-p Can you point me to the Travis build which was the reason for adding the DEFAULT NULL clauses to the create_db_mysql.pl script?

mtoma
mtoma reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@mtoma mtoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source of our problems is described here:
https://dev.mysql.com/doc/refman/5.5/en/timestamp-initialization.html

mtoma
mtoma reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@mtoma mtoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

96a441a

Is the way to set default values for timestamps now.

@matsduf
Copy link
Contributor

matsduf commented Oct 1, 2019

Is the change compatible with older versions of Mysql? And with MariaDB?

mtoma
mtoma reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@mtoma mtoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I don't have older versions of MySQL. It works for MariaDB 10.3.17.

@mattias-p mattias-p closed this Oct 1, 2019
@mattias-p mattias-p deleted the travis branch April 28, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtoma mtoma mtoma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattias-p @matsduf @mtoma