Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly consume pr title and cronjob batch v1 #335

Merged
merged 4 commits into from
Jul 22, 2024
Merged

fix: correctly consume pr title and cronjob batch v1 #335

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9955b0
fix: correctly consume pr title
shreddedbacon Jul 22, 2024
d3580e1
fix: batch v1 not v1beta1
shreddedbacon Jul 22, 2024
268d559
fix: check nativecronjobs
shreddedbacon Jul 22, 2024
de73960
chore: use os instead of io/ioutil
shreddedbacon Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: use os instead of io/ioutil
  • Loading branch information
@shreddedbacon
shreddedbacon committed Jul 22, 2024
commit de7396016ca0e095d3a55e6ad063f23c985f4ab8
5 changes: 2 additions & 3 deletions cmd/template_ingress_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package cmd
import (
"encoding/base64"
"fmt"
"io/ioutil"
"os"
"reflect"
"strings"
Expand Down Expand Up @@ -449,11 +448,11 @@ func TestTemplateRoutes(t *testing.T) {
}

if !tt.wantErr {
files, err := ioutil.ReadDir(savedTemplates)
files, err := os.ReadDir(savedTemplates)
if err != nil {
t.Errorf("couldn't read directory %v: %v", savedTemplates, err)
}
results, err := ioutil.ReadDir(tt.want)
results, err := os.ReadDir(tt.want)
if err != nil {
t.Errorf("couldn't read directory %v: %v", tt.want, err)
}
Expand Down
Loading