Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly consume pr title and cronjob batch v1 #335

Merged
merged 4 commits into from
Jul 22, 2024
Merged

fix: correctly consume pr title and cronjob batch v1 #335

merged 4 commits into from
Jul 22, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 22, 2024 •
edited by tobybellwood
Loading

This PR fixes up a couple of oversight issues in #289

@shreddedbacon shreddedbacon marked this pull request as ready for review July 22, 2024 03:30
@shreddedbacon shreddedbacon changed the title fix: correctly consume pr title fix: correctly consume pr title and cronjob batch v1 Jul 22, 2024
tobybellwood
tobybellwood approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both issues test ok now.

@tobybellwood tobybellwood merged commit 34c77a3 into main Jul 22, 2024
2 checks passed
@tobybellwood tobybellwood deleted the fix-pr-title branch July 22, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood