-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue (#7152 : Improve relation empty states on record page) #7157
base: main
Are you sure you want to change the base?
fix issue (#7152 : Improve relation empty states on record page) #7157
Conversation
falgunmpatel
commented
Sep 19, 2024
- "No xxx" removed for empty relations
- All(0) removed
… page) - "No xxx" removed for empty relations - All(0) removed
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. TODOs/FIXMEs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses issue #7152 by improving the empty state display for relation records on the record page.
- Removed
RecordDetailRelationRecordsListEmptyState
component, eliminating 'No xxx' messages for empty relations - Modified
RecordDetailRelationSection
to hide 'All (0)' link when there are no records - Updated rendering logic in
RecordDetailRelationSection
for a cleaner display of relation records list - Changes align with UX improvement goals by reducing redundant information for empty states
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
@@ -166,7 +163,10 @@ export const RecordDetailRelationSection = ({ | |||
isToManyObjects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: isToManyObjects is used here but not defined. Verify if this should be a boolean check
Thanks @falgunmpatel
|
Thanks for your review @Bonapara . I will keep these points in my mind while solving any issues. Also I will rectify my mistakes in this issue soon. |
- make spaces even for empty records - display icons for empty records while keeping them on hover for other records
Also should I delete the component that I commented. |