Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue (#7152 : Improve relation empty states on record page) #7157

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

falgunmpatel
Copy link

  • "No xxx" removed for empty relations
  • All(0) removed

… page)

- "No xxx" removed for empty relations
- All(0) removed
Copy link

github-actions bot commented Sep 19, 2024

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

TODOs/FIXMEs:

  • //TODO : File no longer needed, after solving (issue: #7152 :- Improve relation empty states on record page): packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListEmptyState.tsx

Generated by 🚫 dangerJS against f817557

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses issue #7152 by improving the empty state display for relation records on the record page.

  • Removed RecordDetailRelationRecordsListEmptyState component, eliminating 'No xxx' messages for empty relations
  • Modified RecordDetailRelationSection to hide 'All (0)' link when there are no records
  • Updated rendering logic in RecordDetailRelationSection for a cleaner display of relation records list
  • Changes align with UX improvement goals by reducing redundant information for empty states

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

@@ -166,7 +163,10 @@ export const RecordDetailRelationSection = ({
isToManyObjects
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: isToManyObjects is used here but not defined. Verify if this should be a boolean check

@Bonapara
Copy link
Member

Bonapara commented Sep 19, 2024

Thanks @falgunmpatel

  • The gap below the relation name should match the gap above it. (Make sure the spacing remains as today when there are some relations under though 🚨)
  • You also missed the point about showing the CTA when there is no relation displayed

image

@falgunmpatel
Copy link
Author

Thanks for your review @Bonapara . I will keep these points in my mind while solving any issues. Also I will rectify my mistakes in this issue soon.

falgunmpatel and others added 2 commits September 19, 2024 22:46
- make spaces even for empty records
- display icons for empty records while keeping them on hover for other records
@falgunmpatel
Copy link
Author

Thanks for your review @Bonapara . I will keep these points in my mind while solving any issues. Also I will rectify my mistakes in this issue soon.

Also should I delete the component that I commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants