Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve relation empty states on record page #7152

Open
Bonapara opened this issue Sep 19, 2024 · 2 comments
Open

Improve relation empty states on record page #7152

Bonapara opened this issue Sep 19, 2024 · 2 comments
Assignees
@falgunmpatel
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Sep 19, 2024 •
edited
Loading

Current behavior

The empty relation states are displayed like this, taking up too much unnecessary space.

CleanShot 2024-09-19 at 15 38 20

Desired Behavior

  • Remove the "No XXX" empty state
  • Remove the All(0) button when there is no relation
  • When there is no relation set, display the "+" or "pen" icon button that allows to add or modify the relation. Keep it on hover when there is a relation to lighten the interface.

image

Figma

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=32530-139682&node-type=frame&t=VEnadEyAJpb29rmb-11
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: low labels Sep 19, 2024
@falgunmpatel
Copy link

@Bonapara May i work on this issue?

falgunmpatel added a commit to falgunmpatel/twenty that referenced this issue Sep 19, 2024
@falgunmpatel
solves issue (twentyhq#7152 : Improve relation empty states on record…
d0b34ce 
… page)

- "No xxx" removed for empty relations
- All(0) removed
@greptile-apps greptile-apps bot mentioned this issue Sep 19, 2024
Open
@Bonapara
Copy link
Member Author

Sure @falgunmpatel, thanks for contributing!

falgunmpatel added a commit to falgunmpatel/twenty that referenced this issue Sep 19, 2024
@falgunmpatel
fix issue (twentyhq#7152 : Improve relation empty states on record page)
71ca503 
- make spaces even for empty records
- display icons for empty records while keeping them on hover for other records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@falgunmpatel falgunmpatel

Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bonapara @falgunmpatel