Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typography tokens resolution #3157

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

akshay-gupta7
Copy link
Contributor

@akshay-gupta7 akshay-gupta7 commented Sep 26, 2024

Addresses #3118

Description

Fixes a bug occurring when a user applies a typography token on a text node, and then applies another token, tinkering with an individual typography property(like font size or font family, etc.), and the user clicks on 'Apply to selection', the typography token overrides the individual token property, which is not expected behaviour.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • None of the above

How to test this

  • Create a typography token with references
  • Apply the token to a text
  • Apply a any token overriding one of the typography properties(like font size, or font family)
  • Then Apply to selection
  • The individual token typography should be applied and work as expected

Screenshots or video (if necessary):

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: f5ece84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@akshay-gupta7 akshay-gupta7 self-assigned this Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

@akshay-gupta7 akshay-gupta7 linked an issue Sep 26, 2024 that may be closed by this pull request
@akshay-gupta7 akshay-gupta7 marked this pull request as draft September 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typography Composite Token not being Overridden
1 participant