Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography Composite Token not being Overridden #3118

Open
keeganedwin opened this issue Sep 3, 2024 · 2 comments · May be fixed by #3157
Open

Typography Composite Token not being Overridden #3118

keeganedwin opened this issue Sep 3, 2024 · 2 comments · May be fixed by #3157
Assignees
Labels
bug Something isn't working needs-responder token type typography composite token type

Comments

@keeganedwin
Copy link
Collaborator

Describe the bug
In 38.9 users were able to override a single property of a typography composite token with the appropriate token type. For example, if a typography token is applied, a user can override just the fontFamily property with a font-family token. This is however no longer possible in 2.0 and proceeding versions.

To Reproduce
Steps to reproduce the behavior:

  1. Create a typography token with references
  2. Apply the token to a text
  3. Apply a any token overriding one of the typography properties
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots or Screencasts
If applicable, add screenshots to help explain your problem.

Figma file (optional)
Send us the link to a Figma file containing a reproducible example

JSON (optional)
If possible, attach the JSON that leads to this bug.

@keeganedwin keeganedwin added bug Something isn't working token type composition TS legacy token type deprecated TBD labels Sep 3, 2024
@six7
Copy link
Collaborator

six7 commented Sep 14, 2024

I think this is solved in 2.1.0 - can you confirm @keeganedwin ?

@keeganedwin
Copy link
Collaborator Author

I think this is solved in 2.1.0 - can you confirm @keeganedwin ?

Bug is still present

@akshay-gupta7 akshay-gupta7 self-assigned this Sep 24, 2024
@akshay-gupta7 akshay-gupta7 added token type typography composite token type and removed token type composition TS legacy token type deprecated TBD labels Sep 24, 2024
@akshay-gupta7 akshay-gupta7 linked a pull request Sep 26, 2024 that will close this issue
5 tasks
@akshay-gupta7 akshay-gupta7 linked a pull request Sep 26, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-responder token type typography composite token type
Projects
Status: 📥 Triage
Development

Successfully merging a pull request may close this issue.

4 participants