Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3916 #3919

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

Issue 3916 #3919

wants to merge 2 commits into from

Conversation

sinkcup
Copy link
Contributor

@sinkcup sinkcup commented Jan 26, 2019

Fixes #3916 Fixes #2327

@emptynick
Copy link
Collaborator

Same as #3912

Pull requests should have descriptive titles and ideally a description of what is being fixed and why (the why can include a link back to the original issue). What you've created here is useless to us without more info

@sinkcup
Copy link
Contributor Author

sinkcup commented Jan 29, 2019

DRY: do not repeat yourself.

pull request should write nothing, but bind a issue, all description are in the issue.

@fletch3555
Copy link
Collaborator

DRY refers to code, not pull requests. If a project maintainer requests you do something a certain way on their project, you should probably do it.

Adding a description makes our lives easier. We're not asking for a 200-slide presentation on how your 2-line change works, but a "x is broken, so this fixes it by doing y instead" would be enough

@sinkcup
Copy link
Contributor Author

sinkcup commented Jan 30, 2019

#3916 is broken, I have fixed it.

is it OK? everything need follow DRY.

look at larapack/hooks#41 , A good project maintainer should never break standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants