-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composer.json broke by hook setup #41
Comments
Same as the Voyager issue you created... uhhh what? There's no error in your screenshot |
Error: No newline at end of file do you known Git/Linux/Mac demand "every line in text should end with a line break"? |
Does it cause you any problems? Thats not a "demand" as much as it is a "standard". If it's not causing problems (which I know its not since 1000's of devs have been using this for over a year), then just ignore it. Or add it back yourself |
It makes big problem: As a programmer, you should follow standards, break rules. I have fixed it, check the PR. |
It doesn't add anything to git, that's on you as the dev. You're welcome to add the line before committing if you so desire. There's no got warning at all, not will it block you from committing other changes. I'm not saying you (we) shouldn't follow standards. What I am saying is that you're making a huge deal out of nothing |
There is testing before commit, you known? Every time I run
|
We have no control over any pre-commit hooks you may have added to your project. There is nothing in the core functionality of git that would block the commit simply for a missing newline at the end of a file. Git simply doesn't care. |
this install changes your bug trouble all developers, every time "change back manually" is not a good idea. |
@emptynick is anybody there? |
You are the first one with troubles because of this |
ha ha. in any case, a package should not change my |
If you dont want hooks to change your |
I had fix it, check the PR #42 |
bug is bug, small bug is bug too. Don't look for any excuses. |
Description:
composer.json
broke by hook setupSteps To Reproduce:
Error: No newline at end of file
The text was updated successfully, but these errors were encountered: