-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codefreeze 09.12 #1645
Merged
Merged
Codefreeze 09.12 #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make prettier and eslint play nice * add lint:ci so will fail in ci * format all the files * organize imports on save * update snaps from tailwind class order changes * update snaps * add recommended extensions * pr feedback
* Use CodeMirror for event history payloads * Add readonly prop * WIP: add copy icon to copy content in JSONEditor * Make codemirror the new CodeBlock. Need to figure out string new lines and how to update editor on content changes * Add folding, make string the type for content, update styles, make dynamic, remove PRISM * Fix extra stringifying * Fix small issues * Remove null check * Use margin * Fix CodeBlock testid * Add editable class to codeblock * Fix playwright payload tests, better extension logic to prevent lineWrapping on inline codeblocks * Make it more readable, add back storageState
* Reset filter when closing ExecutionStatus menu and remove Apply button * Add All option
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
September 25, 2023 16:56
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
* fix button types so `disabled` can't be used with `href` * fix schedules page buttons
KATIETOLER
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Merge in codefreeze branch to main
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?