Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codefreeze 09.12 #1645

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Codefreeze 09.12 #1645

merged 9 commits into from
Sep 25, 2023

Conversation

Alex-Tideman
Copy link
Contributor

Description & motivation 💭

Merge in codefreeze branch to main

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

rossedfort and others added 5 commits September 13, 2023 14:01
* make prettier and eslint play nice

* add lint:ci so will fail in ci

* format all the files

* organize imports on save

* update snaps from tailwind class order changes

* update snaps

* add recommended extensions

* pr feedback
* Use CodeMirror for event history payloads

* Add readonly prop

* WIP: add copy icon to copy content in JSONEditor

* Make codemirror the new CodeBlock. Need to figure out string new lines and how to update editor on content changes

* Add folding, make string the type for content, update styles, make dynamic, remove PRISM

* Fix extra stringifying

* Fix small issues

* Remove null check

* Use margin

* Fix CodeBlock testid

* Add editable class to codeblock

* Fix playwright payload tests, better extension logic to prevent lineWrapping on inline codeblocks

* Make it more readable, add back storageState
* Reset filter when closing ExecutionStatus menu and remove Apply button

* Add All option
@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storybook ❌ Failed (Inspect) Sep 25, 2023 6:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
holocene ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2023 6:30pm

* fix button types so `disabled` can't be used with `href`

* fix schedules page buttons
Copy link
Collaborator

@KATIETOLER KATIETOLER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Alex-Tideman Alex-Tideman merged commit aa9908a into main Sep 25, 2023
12 of 13 checks passed
@Alex-Tideman Alex-Tideman deleted the codefreeze-09.12 branch September 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants