-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codefreeze branch regex to actions #1636
Merged
Alex-Tideman
merged 1 commit into
codefreeze-09.12
from
add-codefreeze-branch-to-actions
Sep 13, 2023
Merged
Add codefreeze branch regex to actions #1636
Alex-Tideman
merged 1 commit into
codefreeze-09.12
from
add-codefreeze-branch-to-actions
Sep 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
laurakwhit
approved these changes
Sep 13, 2023
Alex-Tideman
added a commit
that referenced
this pull request
Sep 25, 2023
* Fix prettier and update to eslint-plugin-svelte (#1621) * make prettier and eslint play nice * add lint:ci so will fail in ci * format all the files * organize imports on save * update snaps from tailwind class order changes * update snaps * add recommended extensions * pr feedback * Add codefreeze branch regex to actions (#1636) * CodeMirror for CodeBlock (#1635) * Use CodeMirror for event history payloads * Add readonly prop * WIP: add copy icon to copy content in JSONEditor * Make codemirror the new CodeBlock. Need to figure out string new lines and how to update editor on content changes * Add folding, make string the type for content, update styles, make dynamic, remove PRISM * Fix extra stringifying * Fix small issues * Remove null check * Use margin * Fix CodeBlock testid * Add editable class to codeblock * Fix playwright payload tests, better extension logic to prevent lineWrapping on inline codeblocks * Make it more readable, add back storageState * [DT-1360] Updates to ExecutionStatus filter (#1641) * Reset filter when closing ExecutionStatus menu and remove Apply button * Add All option * Add Caller-Type to http headers, allow in ui-server, update tests (#1634) * Fix button so that it can't accept an `href` prop if disabled (#1642) * fix button types so `disabled` can't be used with `href` * fix schedules page buttons * upgrade cypress to v13.2.0 and associated changes * upgrade cypress github action to v6 * prettierignore cypress/downloads --------- Co-authored-by: Ross Edfort <rossedfort@gmail.com> Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
Alex-Tideman
added a commit
that referenced
this pull request
Oct 17, 2023
* Fix prettier and update to eslint-plugin-svelte (#1621) * make prettier and eslint play nice * add lint:ci so will fail in ci * format all the files * organize imports on save * update snaps from tailwind class order changes * update snaps * add recommended extensions * pr feedback * Add codefreeze branch regex to actions (#1636) * CodeMirror for CodeBlock (#1635) * Use CodeMirror for event history payloads * Add readonly prop * WIP: add copy icon to copy content in JSONEditor * Make codemirror the new CodeBlock. Need to figure out string new lines and how to update editor on content changes * Add folding, make string the type for content, update styles, make dynamic, remove PRISM * Fix extra stringifying * Fix small issues * Remove null check * Use margin * Fix CodeBlock testid * Add editable class to codeblock * Fix playwright payload tests, better extension logic to prevent lineWrapping on inline codeblocks * Make it more readable, add back storageState * WIP: get decoding working on expand * Show the full payloadable, add to input and results * Clean up all the functions * Use onMount instead * Try to check the hash * Remove blakejs * Add cloneAllPotentialPayloadsWithCodec fn * Show null values * Delete all the port code, fix all tests and types and linting * Remove console.log * Don't add check, always use payloads key * Remove console.log and add key block on json navigator * Remove port test * Refactor fetchAllEvents to the workflow-history-layout. Fix timeline issue with json. Add loading to timeline * Add back loading check for empty row --------- Co-authored-by: Ross Edfort <rossedfort@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Run lint and test actions on
codefreeze-*
branch pull requestsScreenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?