Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supportsAdvancedVisibility to check for v1.20 #1165

Merged
merged 21 commits into from
Feb 24, 2023
Merged

Update supportsAdvancedVisibility to check for v1.20 #1165

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
723a2c6
Add check for 1.20 version for advanced vis
Alex-Tideman Feb 7, 2023
cd2e4fc
Merge branch 'main' into DT-341
Alex-Tideman Feb 10, 2023
23a130d
Add unit tests
Alex-Tideman Feb 13, 2023
3a6a396
Merge branch 'main' into DT-341
Alex-Tideman Feb 14, 2023
a1c6edf
Add supportsAdvancedVisibilityFully for > 1.20 for count/batch and so…
Alex-Tideman Feb 14, 2023
40c35db
Add check for supportsAdvancedVisibility for datetime query
Alex-Tideman Feb 15, 2023
62f1dc3
Add cypress tests with mysql and 1.20
Alex-Tideman Feb 15, 2023
6aff484
Fix .env
Alex-Tideman Feb 15, 2023
a77ec29
Fix logic for checks with isCloud
Alex-Tideman Feb 15, 2023
555f923
Update cypress tests, remove unused code
Alex-Tideman Feb 16, 2023
bd31529
Test updates
Alex-Tideman Feb 16, 2023
a6da0d1
Update json
Alex-Tideman Feb 17, 2023
efad911
Merge branch 'main' into DT-341
Alex-Tideman Feb 17, 2023
126f1ef
Speed up tests failures
stevekinney Feb 17, 2023
56c0612
Update playwright.config.ts
stevekinney Feb 17, 2023
6ade923
Mock cluster api, add favicon in static to remove error
Alex-Tideman Feb 17, 2023
8f82933
Merge branch 'main' into DT-341-advanced-vis
Alex-Tideman Feb 23, 2023
64991b5
Merge branch 'main' into DT-341-advanced-vis
Alex-Tideman Feb 24, 2023
3ac1ffc
Remove max-length-line for now
Alex-Tideman Feb 24, 2023
390a817
Run format
Alex-Tideman Feb 24, 2023
702766b
Add longer time out on time range tests
Alex-Tideman Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update cypress tests, remove unused code
  • Loading branch information
@Alex-Tideman
Alex-Tideman committed Feb 16, 2023
commit 555f92342fee399fa005d9f969086bbd1f3d41c7
8 changes: 4 additions & 4 deletions cypress/integration/workflow-executions-with-new-search.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ describe('Workflow Executions List With Search', () => {
cy.get('#time-range-filter').click();
cy.contains('15 minutes').click();

cy.url().should('contain', 'StartTime+>');
cy.url().should('contain', 'StartTime+%3E');
cy.get('[data-testid="workflow-count"]').should(
'have.text',
'Results 15 of 15 workflows',
Expand All @@ -167,7 +167,7 @@ describe('Workflow Executions List With Search', () => {
cy.contains('3 hours').click();
cy.contains('End Time').click();

cy.url().should('contain', 'CloseTime+>');
cy.url().should('contain', 'CloseTime+%3E');
cy.get('[data-testid="workflow-count"]').should(
'have.text',
'Results 15 of 15 workflows',
Expand Down Expand Up @@ -371,7 +371,7 @@ describe('Workflow Executions List With Search using only MySql on 1.20', () =>
cy.get('#time-range-filter').click();
cy.contains('15 minutes').click();

cy.url().should('contain', 'StartTime+>');
cy.url().should('contain', 'StartTime+%3E');
cy.get('[data-testid="workflow-count"]').should(
'have.text',
'Results 15 of 15 workflows',
Expand All @@ -383,7 +383,7 @@ describe('Workflow Executions List With Search using only MySql on 1.20', () =>
cy.contains('3 hours').click();
cy.contains('End Time').click();

cy.url().should('contain', 'CloseTime+>');
cy.url().should('contain', 'CloseTime+%3E');
cy.get('[data-testid="workflow-count"]').should(
'have.text',
'Results 15 of 15 workflows',
Expand Down
7 changes: 3 additions & 4 deletions src/lib/stores/bulk-actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ export const supportsAdvancedVisibility = derived(
);

export const supportsAdvancedVisibilityWithOrderBy = derived(
[cluster, temporalVersion, isCloud],
([$cluster, $temporalVersion, $isCloud]) =>
advancedVisibilityEnabledWithOrderBy($cluster, $temporalVersion) ||
$isCloud,
[cluster, isCloud],
([$cluster, $isCloud]) =>
advancedVisibilityEnabledWithOrderBy($cluster) || $isCloud,
);
2 changes: 0 additions & 2 deletions src/lib/utilities/advanced-visibility-enabled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ export const advancedVisibilityEnabled = (
// Add isVersionNewer check when we know when orderBy is supported
export const advancedVisibilityEnabledWithOrderBy = (
cluster: ClusterInformation,
version: string,
) => {
return cluster?.visibilityStore?.includes('elasticsearch');
// || isVersionNewer(version, '1.20')
};