Update supportsAdvancedVisibility to check for v1.20 #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
stevekinney
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Updated supportsAdvancedVisibility to check for 1.20 or newer version of Temporal. This will allow mysql/postgres visibility stores to use new filters.
If supportsAdvancedVisibility, update the DateTime query to use > instead of BETWEEN logic.
Disabled sorting UI for Start/Close Time if not using elastic search for now.
Why?
Temporal v1.20 updated mysql/postgres visibility stores to have (almost) parity with elasticsearch. This PR lets users use our new filter workflow list page if using 1.20.