Add protocol tests for Content-Type params #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested review from
a team and
sugmanue
and removed request for
a team and
syall
sugmanue
approved these changes
Jun 3, 2024
2 tasks
github-merge-queue bot
pushed a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Jun 28, 2024
Fixes: #3471 ## Motivation and Context An issue was raised about a mobile client that appends "; charset=utf-8" to the Content-Type when using restJson1. The [latest RFC](https://www.rfc-editor.org/rfc/rfc8259) for "application/json" does not register a charset parameter, but indicates it is reasonable to accept it. ## Description This change loosens the validation of the expected content type to allow all parameters. ## Testing * Tests for each protocol were added to [smithy](smithy-lang/smithy#2296) * ran the runtime and codegen tests * Added test for rest-xml, as smithy-rs does not currently run the smithy tests. ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This change adds tests to document/enforce how the Content-Type headers should be handled by servers. They are important to ensure that clients get the same experience regardless of which language the server is written in.
These are being added as smithy-rs was rejecting requests with parameters added to the Content-Type header, but the customer's existing requests were being accepted by existing servers.
Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.