Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix protocol tests failing during smithy 1.50.0 update #6246

Open
3 tasks done
trivikr opened this issue Jul 2, 2024 · 1 comment
Open
3 tasks done

Fix protocol tests failing during smithy 1.50.0 update #6246

trivikr opened this issue Jul 2, 2024 · 1 comment
Labels
bug This issue is a bug. p3 This is a minor priority issue queued This issues is on the AWS team's backlog smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch

Comments

@trivikr
Copy link
Member

trivikr commented Jul 2, 2024

Checkboxes for prior research

Describe the bug

Some protocol tests were skipped to unblock upgrading to smithy 1.50.0

SDK version number

main

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

All

Reproduction Steps

Enable protocol tests skipped in #6245 (comment)

Observed Behavior

Protocol tests are failing

Expected Behavior

Protocol tests should not fail

Possible Solution

No response

Additional Information/Context

No response
@trivikr trivikr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p3 This is a minor priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Jul 2, 2024
@trivikr
Copy link
Member Author

trivikr commented Jul 2, 2024

Protocol tests added in:

@kuhe kuhe added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. p3 This is a minor priority issue queued This issues is on the AWS team's backlog smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuhe @trivikr