Short-circuit the actor stack when the user can't edit works #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
actor-add-to-work
branch
from
51b73df
to
b60502e
Compare
In the case that a request to the actor stack tries to add a work to a parent that the current ability cannot edit, we want to avoid doing so. Previously, we allowed the stack to carry on creating the new work, only to fail at the end--with an incomplete work. This leaves the application data in an undesirable state. Here, we eagerly fail by checking the permissions of the target works before continuing with the stack. If we don't have the correct permissions, we avoid creating any works.
no-reply
force-pushed
the
actor-add-to-work
branch
from
b60502e
to
da2351c
Compare
|
this would benefit from a backport to |
laritakr
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that a request to the actor stack tries to add a work to a parent
that the current ability cannot edit, we want to avoid doing so.
Previously, we allowed the stack to carry on creating the new work, only to fail
at the end--with an incomplete work. This leaves the application data in an
undesirable state.
Here, we eagerly fail by checking the permissions of the target works before
continuing with the stack. If we don't have the correct permissions, we avoid
creating any works.
@samvera/hyrax-code-reviewers