Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply add to work permission fix to 2.x branch #3848

Closed
laritakr opened this issue Jun 24, 2019 · 0 comments
Closed

Apply add to work permission fix to 2.x branch #3848

laritakr opened this issue Jun 24, 2019 · 0 comments
Assignees
@laritakr

Comments

@laritakr
Copy link
Contributor

laritakr commented Jun 24, 2019 •
edited
Loading

Descriptive summary

Pull request #3845 corrected a permission error in the actor stack when adding a new work to an existing work.

This behavior needs to be added to the 2.x branch (not a straight backport due to the new wings code).
@laritakr laritakr self-assigned this Jun 25, 2019
@laritakr laritakr changed the title Apply add to work permission fix to 2.1.x branch Apply add to work permission fix to 2.x branch Jun 25, 2019
laritakr pushed a commit that referenced this issue Jun 25, 2019
Backport add_to_work_actor permission check
d49ecbb 
Completes #3848

In the case that a request to the actor stack tries to add a work to a parent
that the current ability cannot edit, we want to avoid doing so.

Previously, we allowed the stack to carry on creating the new work, only to fail
at the end--with an incomplete work. This leaves the application data in an
undesirable state.
@laritakr laritakr mentioned this issue Jun 25, 2019
Merged
laritakr pushed a commit that referenced this issue Jun 25, 2019
Backport add_to_work_actor permission check
27351c9 
Completes #3848

In the case that a request to the actor stack tries to add a work to a parent
that the current ability cannot edit, we want to avoid doing so.

Previously, we allowed the stack to carry on creating the new work, only to fail
at the end--with an incomplete work. This leaves the application data in an
undesirable state.
laritakr pushed a commit that referenced this issue Jun 25, 2019
Backport add_to_work_actor permission check
3212163 
Completes #3848

In the case that a request to the actor stack tries to add a work to a parent
that the current ability cannot edit, we want to avoid doing so.

Previously, we allowed the stack to carry on creating the new work, only to fail
at the end--with an incomplete work. This leaves the application data in an
undesirable state.
laritakr pushed a commit that referenced this issue Jun 25, 2019
Backport add_to_work_actor permission check
4f363c7 
Completes #3848

In the case that a request to the actor stack tries to add a work to a parent
that the current ability cannot edit, we want to avoid doing so.

Previously, we allowed the stack to carry on creating the new work, only to fail
at the end--with an incomplete work. This leaves the application data in an
undesirable state.
@jeremyf jeremyf mentioned this issue Feb 2, 2020
Merged
@jeremyf jeremyf mentioned this issue Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laritakr laritakr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laritakr