[hud][ch] Viable strict lag query #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
clee2000
force-pushed
the
csl/ch_strict_lag_sec
branch
from
d8d5f5d
to
97a0e6c
Compare
huydhn
reviewed
Aug 28, 2024
| push | ||
| WHERE | ||
| push.ref = {head: String } | ||
| AND push.repository.owner.name = 'pytorch' |
There was a problem hiding this comment.
Nit: Should we add a parameter for owner here too instead of fixing it as pytorch? It's a trivial fix
There was a problem hiding this comment.
Done, its not a param for the rockset version tho, but it doesn't get used anywhere so its fine imo
huydhn
approved these changes
Aug 28, 2024
clee2000
force-pushed
the
csl/ch_strict_lag_sec
branch
from
76e9253
to
29da525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.