[hud][ch] Viable strict lag query (#5606)

pytorch · Aug 28, 2024 · 15a9c4e · 15a9c4e
1 parent f9b6344
commit 15a9c4e
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 15 deletions.
diff --git a/torchci/clickhouse_queries/strict_lag_sec/params.json b/torchci/clickhouse_queries/strict_lag_sec/params.json
@@ -1,4 +1,5 @@
 {
+  "repo": "String",
   "head": "String",
-  "repo": "String"
-}
+  "owner": "String"
+}
diff --git a/torchci/clickhouse_queries/strict_lag_sec/query.sql b/torchci/clickhouse_queries/strict_lag_sec/query.sql
@@ -1,30 +1,29 @@
--- !!! Query is not converted to CH syntax yet.  Delete this line when it gets converted
 WITH master as (
     SELECT
-        PARSE_TIMESTAMP_ISO8601(push.head_commit.timestamp) as master
+        push.head_commit.timestamp as master
     FROM
         push
     WHERE
-        push.ref = :head
-        AND push.repository.owner.name = 'pytorch'
-        AND push.repository.name = :repo
-        AND push.head_commit is not null
+        push.ref = {head: String }
+        AND push.repository.owner.name = {owner: String }
+        AND push.repository.name = {repo: String }
+        AND push.head_commit.id != ''
     ORDER BY
-        push._event_time desc
+        push.head_commit.timestamp desc
     LIMIT
         1
 ), strict as (
     SELECT
-        PARSE_TIMESTAMP_ISO8601(push.head_commit.timestamp) as strict
+        push.head_commit.timestamp as strict
     FROM
         push
     WHERE
         push.ref = 'refs/heads/viable/strict'
-        AND push.repository.owner.name = 'pytorch'
-        AND push.repository.name = :repo
-        AND push.head_commit is not null
+        AND push.repository.owner.name = {owner: String }
+        AND push.repository.name = {repo: String }
+        AND push.head_commit.id != ''
     ORDER BY
-        push._event_time desc
+        push.head_commit.timestamp desc
     LIMIT
         1
 )

diff --git a/torchci/pages/metrics.tsx b/torchci/pages/metrics.tsx
@@ -681,8 +681,17 @@ export default function Page() {
               queryName={"strict_lag_sec"}
               metricName={"strict_lag_sec"}
               valueRenderer={(value) => durationDisplay(value)}
-              queryParams={[]}
+              queryParams={
+                useClickHouse
+                  ? {
+                      repo: "pytorch",
+                      owner: "pytorch", // Not a parameter for the rockset query
+                      head: "refs/heads/main",
+                    }
+                  : []
+              }
               badThreshold={(value) => value > 60 * 60 * 6} // 6 hours
+              useClickHouse={useClickHouse}
             />
             <ScalarPanel
               title={"# disabled tests"}