Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-41100: Support macOS 11 and Apple Silicon (GH-22855) #23295

Merged
merged 3 commits into from
Nov 22, 2020

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Nov 15, 2020

Co-authored-by: Lawrence D’Anna lawrence_danna@apple.com

  • Add support for macOS 11 and Apple Silicon (aka arm64)

    As a side effect of this work use the system copy of libffi on macOS, and remove the vendored copy

  • Support building on recent versions of macOS while deploying to older versions

    This allows building installers on macOS 11 while still supporting macOS 10.9..
    (cherry picked from commit 4176193)

This also back ports #23279 and #23280 which fix minor issues in the back ported PR.

Co-authored-by: Ronald Oussoren ronaldoussoren@mac.com

https://bugs.python.org/issue41100

Co-authored-by:  Lawrence D’Anna <lawrence_danna@apple.com>

* Add support for macOS 11 and Apple Silicon (aka arm64)

  As a side effect of this work use the system copy of libffi on macOS, and remove the vendored copy

* Support building on recent versions of macOS while deploying to older versions

  This allows building installers on macOS 11 while still supporting macOS 10.9..
(cherry picked from commit 4176193)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@ronaldoussoren
Copy link
Contributor Author

This PR needs work, we merged some changes before moving the large PR this is based on.

@ronaldoussoren ronaldoussoren marked this pull request as ready for review November 21, 2020 12:50
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Using this PR along with the 3.9 backports of bpo-41116 and bpo-42361, I built a "python.org-style" macOS installer on macOS 11.0.1 (Intel) and tested on 11.0.1 (Apple Silcon), 11.0.1 (Intel-64), and 10.9 (Intel-64) with no major regressions noted. (There are some issues with IDLE because of the change of Tcl/Tk from 8.6.8 to 8.6.10 but otherwise unrelated to this PR; will followup on those in a separate issue. Note that this does not affect the current 10.9 installer variant which will remain the default download installer variant for 3.9.1.)

@ronaldoussoren ronaldoussoren merged commit e8b1c03 into python:3.9 Nov 22, 2020
colesbury referenced this pull request in colesbury/nogil Oct 7, 2021
…295)

* [3.9] bpo-41100: Support macOS 11 and Apple Silicon (GH-22855)

Co-authored-by:  Lawrence D’Anna <lawrence_danna@apple.com>

* Add support for macOS 11 and Apple Silicon (aka arm64)

  As a side effect of this work use the system copy of libffi on macOS, and remove the vendored copy

* Support building on recent versions of macOS while deploying to older versions

  This allows building installers on macOS 11 while still supporting macOS 10.9..
(cherry picked from commit 4176193)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>

* Back port of changes to _decimal to support arm64

* temp_dir is in test.support in 3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants