Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42361: Use Tcl/Tk 8.6.10 when building the installer on recent macOS #23293

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Nov 15, 2020

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.

https://bugs.python.org/issue42361

Automerge-Triggered-By: GH:ned-deily

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle

@miss-islington
Copy link
Contributor

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @ronaldoussoren, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 690a5fa3ddc675a434730b057ddb5c33f44fd0b7 3.9

@miss-islington
Copy link
Contributor

Sorry @ronaldoussoren, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 690a5fa3ddc675a434730b057ddb5c33f44fd0b7 3.8

@ned-deily
Copy link
Member

ned-deily commented Nov 22, 2020

Note, the merge conflict for 3.9 should disappear after the merge of GH-23295, the 3.9 backport of bpo-41100, macOS Big Sur and Apple Silicon Macs support.

@ned-deily ned-deily added needs backport to 3.9 only security fixes and removed needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Nov 22, 2020
@miss-islington
Copy link
Contributor

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-23465 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 22, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 22, 2020
…cOS (pythonGH-23293)

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.
(cherry picked from commit 690a5fa)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
miss-islington added a commit that referenced this pull request Nov 22, 2020
…cOS (GH-23293)

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.
(cherry picked from commit 690a5fa)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…cOS (pythonGH-23293)

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants