Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121905: Consistently use "floating-point" instead of "floating point" #121907

Merged
merged 8 commits into from
Jul 19, 2024
Merged

gh-121905: Consistently use "floating-point" instead of "floating point" #121907

merged 8 commits into from
Jul 19, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 17, 2024 •
edited by github-actions bot
Loading

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news labels Jul 17, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 17, 2024
Closed
@serhiy-storchaka
Copy link
Member Author

I tried to only use "floating-point" for adjectives, like "floating-point number" and "floating-point arithmetic", not for nouns, like "binary floating point" and "decimal floating point", and not change book names, but it needs third party verification. Maybe there are other cases in which the hyphen is not desirable.

@erlend-aasland erlend-aasland mentioned this pull request Jul 17, 2024
Merged
@AlexWaygood
Copy link
Member

I tried to only use "floating-point" for adjectives, like "floating-point number" and "floating-point arithmetic", not for nouns, like "binary floating point" and "decimal floating point", and not change book names, but it needs third party verification. Maybe there are other cases in which the hyphen is not desirable.

This is the correct distinction; your choices all look correct to me

AA-Turner
AA-Turner approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a brief look through everything and can't spot any obvious problems. I agree re using the hyphenated form.

A

Doc/c-api/float.rst Show resolved Hide resolved
Doc/faq/programming.rst Outdated Show resolved Hide resolved
Doc/reference/datamodel.rst Outdated Show resolved Hide resolved
Doc/tutorial/floatingpoint.rst Show resolved Hide resolved
@rhettinger rhettinger removed their request for review July 18, 2024 01:45
mdickinson
mdickinson approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed line-by-line, but the change LGTM in principle.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 18, 2024
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) July 19, 2024 07:42
@serhiy-storchaka serhiy-storchaka merged commit 1a0c7b9 into python:main Jul 19, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a0c7b9ba48a2dffb70bb0c7327abae1d3e87356 3.13

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a0c7b9ba48a2dffb70bb0c7327abae1d3e87356 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 19, 2024
@serhiy-storchaka
[3.13] pythongh-121905: Consistently use "floating-point" instead of …
d513ade 
…"floating point" (pythonGH-121907)

(cherry picked from commit 1a0c7b9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2024

GH-122012 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 19, 2024
@serhiy-storchaka
pythongh-121905: Consistently use "floating-point" instead of "floati…
31868ad 
…ng point" (pythonGH-121907)

(cherry picked from commit 1a0c7b9)
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2024

GH-122013 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 19, 2024
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2024
@serhiy-storchaka
[3.12] gh-121905: Consistently use "floating-point" instead of "float…
39dea21 
…ing point" (GH-121907) (GH-122013)

(cherry picked from commit 1a0c7b9)
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2024
@serhiy-storchaka
[3.13] gh-121905: Consistently use "floating-point" instead of "float…
a45d905 
…ing point" (GH-121907) (GH-122012)

(cherry picked from commit 1a0c7b9)
@serhiy-storchaka serhiy-storchaka deleted the docs-floating-point branch July 19, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@ezio-melotti ezio-melotti ezio-melotti left review comments

@mdickinson mdickinson mdickinson approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @AlexWaygood @mdickinson @AA-Turner @ezio-melotti