Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'time zone' in a Specific words section #1352

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented Jul 15, 2024

python/cpython#118449 corrects "timezone" to "time zone". This records the guidance for posterity.


📚 Documentation preview 📚: https://cpython-devguide--1352.org.readthedocs.build/

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could perhaps use a .. glossary:: directive here?

A

Comment on lines 89 to 90
Only spell as one word when referring to a Python term like a module,
class, or argument.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't they have markup like :mod: or similar in this case?
If that's the case, "timezone" should never appear in plain text.
Not sure if it's worth clarifying this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's worth clarifying this.

Anyone reading the devguide style guide will probably already know how to mark up classes, so I'm not sure it's worth complicating the current wording.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant is:

  • talking about the concept? Always use two words and no markup.
  • talking about the module/class/arg? Always use one word and the appropriate markup.

This implies that "timezone" will never appear in plain text and "time zone" will never appear within markup.

IOW, the fact that you are using markup or not already determines whether to use one or two words, without having to think if you are referring to a module/class/argument or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, if it does not clutter the wording too much, I'm fine with such a change.

@nedbat
Copy link
Member Author

nedbat commented Jul 16, 2024

We could perhaps use a .. glossary:: directive here?

I'm not sure this rises to that level yet, but will keep it in mind.

Comment on lines 60 to 63
.. _glossary:

Specific words
==============
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I predict this will confuse me, shall we have the same name for both the link and the title?

Copy link
Member

@ezio-melotti ezio-melotti Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link might also be confused with the glossary directive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the reference to specific words.

@erlend-aasland
Copy link
Contributor

Related:

Comment on lines 88 to 90
Spell out as two words when talking about the real-world concept.
Only spell as one word when referring to a Python term like a module,
class, or argument.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Spell out as two words when talking about the real-world concept.
Only spell as one word when referring to a Python term like a module,
class, or argument.
When referring to a Python term like a module, class, or argument
it is always spelled as one word and surrounded by the appropriate markup
(for example, ``:mod:`timezone```).
When talking about the real-world concept it is spelled as two words.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a modified version of this text.

@nedbat nedbat merged commit c3950af into python:main Jul 18, 2024
4 checks passed
@nedbat nedbat deleted the nedbat/glossary branch July 18, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants