fix(AI Agent Node): Fix issues with some tools not populating #10406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegIvaniv
added
the
release/backport
burivuhster
approved these changes
Aug 14, 2024
|
|
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ghc-158-community-issue-ai-agent-not-recognising-attached-tools
branch
Merged
mutdmour
pushed a commit
that referenced
this pull request
Aug 14, 2024
Merged
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 15, 2024
* master: (22 commits) refactor(editor): Type node view event bus (no-changelog) (#10396) refactor: Update to license SDK v2.13.1 to address dependency updates (#10422) refactor(core): Simplify Redis client types (no-changelog) (#10397) fix: Project Viewer always seeing a connection error when testing credentials (#10417) fix(editor): Fix incorrect node type version selection on new canvas (no-changelog) (#10412) fix(core): Fix payload property in `workflow-post-execute` event (#10413) fix: Require mfa code to change email (#10354) ci: Remove hard-coded package version in unit tests (no-changelog) (#10414) refactor(editor): Remove deleted event name from UI (#10402) 🚀 Release 1.55.0 (#10411) fix: Add better error handling for chat errors (#10408) ci: Trigger Docker releases on tag creation instead of release publishing (no-changelog) (#10409) fix(AI Agent Node): Fix issues with some tools not populating (#10406) feat(AI Transform Node): Telemetry (no-changelog) (#10398) feat(AI Transform Node): New node (#10405) feat: Add Ask assistant behind feature flag (#9995) refactor(editor): Use form event bus everywhere (no-changelog) (#10394) fix: Remove node AI Transform node (no-changelog) (#10400) fix(editor): Remove `@n8n/permissions` from `n8n-workflow` (no-changelog) (#10399) refactor(core): Make new configs consistent (no-changelog) (#10393) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To convert
StructuredDynamicTooltoDynamicToolwe changed some logic ingetConnectedTools, which would skip tools that are not DynamicTool && not N8nTool. This would prevent most of the tools from being used with an agent. This PR removes the check/skipping(if (!(tool instanceof DynamicTool) && !(tool instanceof N8nTool)) continue;) as it makes sense to always check for duplicate tool names, and there's already a check forinstanceof N8nToolin case conversion is required.Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)