refactor(core): Simplify Redis client types (no-changelog) #10397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
tomi
reviewed
Aug 15, 2024
| @@ -0,0 +1,19 @@ | |||
| export type RedisClient = n8nRedisClient | BullRedisClient; | |||
There was a problem hiding this comment.
I believe this is the redis client type (or name?), not the client itself. Maybe we should rename this to RedisClientType and N8nRedisClientType and BullRedisClientType (or *Name?)
| * - `publisher(n8n)` to send messages into scaling mode communication channels | ||
| * - `cache(n8n)` for caching operations (variables, resource ownership, etc.) | ||
| */ | ||
| type n8nRedisClient = 'subscriber(n8n)' | 'publisher(n8n)' | 'cache(n8n)'; |
There was a problem hiding this comment.
TS types should start with a capital letter, even if it's for a name that is normally written with a lowercase letter
Comment on lines
+12
to
+18
| /** | ||
| * Redis client used internally by Bull. Suffixed with `(bull)` at `ScalingService.setupQueue`. | ||
| * | ||
| * - `subscriber(bull)` for event listening | ||
| * - `client(bull)` for general queue operations | ||
| * - `bclient(bull)` for blocking operations when processing jobs | ||
| */ |
tomi
approved these changes
Aug 15, 2024
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 15, 2024
* master: (22 commits) refactor(editor): Type node view event bus (no-changelog) (#10396) refactor: Update to license SDK v2.13.1 to address dependency updates (#10422) refactor(core): Simplify Redis client types (no-changelog) (#10397) fix: Project Viewer always seeing a connection error when testing credentials (#10417) fix(editor): Fix incorrect node type version selection on new canvas (no-changelog) (#10412) fix(core): Fix payload property in `workflow-post-execute` event (#10413) fix: Require mfa code to change email (#10354) ci: Remove hard-coded package version in unit tests (no-changelog) (#10414) refactor(editor): Remove deleted event name from UI (#10402) 🚀 Release 1.55.0 (#10411) fix: Add better error handling for chat errors (#10408) ci: Trigger Docker releases on tag creation instead of release publishing (no-changelog) (#10409) fix(AI Agent Node): Fix issues with some tools not populating (#10406) feat(AI Transform Node): Telemetry (no-changelog) (#10398) feat(AI Transform Node): New node (#10405) feat: Add Ask assistant behind feature flag (#9995) refactor(editor): Use form event bus everywhere (no-changelog) (#10394) fix: Remove node AI Transform node (no-changelog) (#10400) fix(editor): Remove `@n8n/permissions` from `n8n-workflow` (no-changelog) (#10399) refactor(core): Make new configs consistent (no-changelog) (#10393) ...
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client,bclient,consumer,producer,list-sender,list-receivedContext: https://n8nio.slack.com/archives/C069HS026UF/p1723618011118889