Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Stop reporting disk I/O error to Sentry (no-changelog) #10324

Merged
merged 1 commit into from
Aug 8, 2024
Merged

refactor(core): Stop reporting disk I/O error to Sentry (no-changelog) #10324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(core): Stop reporting disk I/O error to Sentry (no-changelog)
  • Loading branch information
@ivov
ivov committed Aug 8, 2024
commit 15627177beb32c1738cbf827bc4094c65fb41800
2 changes: 1 addition & 1 deletion packages/cli/src/ErrorReporting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const initErrorHandling = async () => {

if (
originalException instanceof QueryFailedError &&
originalException.message.includes('SQLITE_FULL')
['SQLITE_FULL', 'SQLITE_IOERR'].some((errMsg) => originalException.message.includes(errMsg))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these errors still logged to console for example? They are noise in Sentry, but for someone maintaining the n8n instance it's probably something you would be interested in knowing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were already not being logged. but now that they are not being sent to Sentry either, maybe we should start logging these? 🤔

) {
return null;
}
Expand Down
Loading