refactor(core): Stop reporting disk I/O error to Sentry (no-changelog) #10324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
approved these changes
Aug 8, 2024
n8n-assistant
bot
added
core
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
tomi
reviewed
Aug 8, 2024
| @@ -69,7 +69,7 @@ export const initErrorHandling = async () => { | |||
|
|
|||
| if ( | |||
| originalException instanceof QueryFailedError && | |||
| originalException.message.includes('SQLITE_FULL') | |||
| ['SQLITE_FULL', 'SQLITE_IOERR'].some((errMsg) => originalException.message.includes(errMsg)) | |||
There was a problem hiding this comment.
Are these errors still logged to console for example? They are noise in Sentry, but for someone maintaining the n8n instance it's probably something you would be interested in knowing
There was a problem hiding this comment.
these were already not being logged. but now that they are not being sent to Sentry either, maybe we should start logging these? 🤔
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 9, 2024
* master: fix(core): Prevent XSS via static cache dir (#10339) fix(editor): Enable credential sharing between all types of projects (#10233) refactor(core): Extract webhook request handler to own file (#10301) feat: Allow sharing to and from team projects (no-changelog) (#10144) refactor(editor): Convert ChangePasswordModal to composition api (no-changelog) (#10337) docs: Change display name for WhatsApp Trigger API Credential (#10334) fix(core): Do not load ScalingService in regular mode (no-changelog) (#10333) docs: Update wording in X credentials (#10327) fix(editor): Fixing XSS vulnerability in toast messages (#10329) fix(core): Rate limit MFA activation and verification endpoints (#10330) refactor(core): Decouple emailing and workflow sharing from internal hooks (no-changelog) (#10326) refactor(core): Stop reporting disk I/O error to Sentry (no-changelog) (#10324)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disk full error is not actionable in-app, so we should not be reporting it.
Example:
server_nameunder Tags)