Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling in custom benchmark #22245

Merged
merged 26 commits into from
Sep 4, 2024
Merged

Error handling in custom benchmark #22245

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f907691
WIP; error handling in custom benchmark
jikim-msft Aug 16, 2024
78fd4b2
change script / add emit event
jikim-msft Aug 22, 2024
9c95ff9
change tree script
jikim-msft Aug 23, 2024
cd3f7c3
lock
jikim-msft Aug 23, 2024
7cefbf5
Merge branch 'main' into benchmark/add-error
jikim-msft Aug 23, 2024
50d72fd
add testcase
jikim-msft Aug 23, 2024
009952d
change variable name
jikim-msft Aug 23, 2024
d98d7ae
change
jikim-msft Aug 23, 2024
02abf87
change benchmark test
jikim-msft Aug 26, 2024
b2a17d1
Merge branch 'main' into benchmark/add-error
jikim-msft Aug 26, 2024
1ea7bc9
add afterEach
jikim-msft Aug 27, 2024
a7332a0
add else
jikim-msft Aug 27, 2024
b778ae4
Merge branch 'main' into benchmark/add-error
jikim-msft Aug 27, 2024
0d95ec9
Update tools/benchmark/src/mocha/customOutputRunner.ts
jikim-msft Aug 28, 2024
5c273b2
add perf
jikim-msft Aug 29, 2024
92c593d
fix reporter
jikim-msft Sep 4, 2024
e8b14b2
Merge branch 'main' into benchmark/add-error
jikim-msft Sep 4, 2024
32ad19b
Merge branch 'main' into benchmark/add-error
jikim-msft Sep 4, 2024
4b39ec3
remove comment
jikim-msft Sep 4, 2024
e81fba4
test skip
jikim-msft Sep 4, 2024
cd9e367
remove
jikim-msft Sep 4, 2024
3cd5069
change type
jikim-msft Sep 4, 2024
4322687
remove if
jikim-msft Sep 4, 2024
2e45555
make error concise
jikim-msft Sep 4, 2024
7309f96
Merge branch 'main' into benchmark/add-error
jikim-msft Sep 4, 2024
3f2a5c1
remove comment
jikim-msft Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@jikim-msft
jikim-msft committed Sep 4, 2024
commit 4b39ec3a4cde7e3235c6dc5b3996e7dd28cf68a7
1 change: 0 additions & 1 deletion tools/benchmark/src/Reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ export class BenchmarkReporter {

table.cell("name", chalk.italic(testName));

// Additional if-statement to display columns in more readble order & avoid reporter from crashing if customData is empty.
if (isResultError(result)) {
table.cell("error", result.error);
} else {
Expand Down
Loading